Summary: | [iOS] Moving backwards by word granularity does not work if the previous line was inside another block element | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
Component: | HTML Editing | Assignee: | Ryosuke Niwa <rniwa> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | ap, darin, ews-watchlist, megan_gardner, rniwa, wenson_hsieh |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=196671 | ||
Attachments: |
Description
Ryosuke Niwa
2019-04-05 22:52:56 PDT
Created attachment 366875 [details]
Fixes the bug
Created attachment 366876 [details]
Fixes the bug
Comment on attachment 366876 [details] Fixes the bug Attachment 366876 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11788918 New failing tests: editing/text-iterator/backwards-text-iterator-basic.html fast/dom/Range/range-expand.html accessibility/mac/text-marker-sentence-nav.html Created attachment 366878 [details]
Archive of layout-test-results from ews103 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 366876 [details] Fixes the bug Attachment 366876 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11788930 New failing tests: editing/text-iterator/backwards-text-iterator-basic.html accessibility/mac/text-marker-sentence-nav.html fast/dom/Range/range-expand.html Created attachment 366879 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 366876 [details] Fixes the bug Attachment 366876 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11789034 New failing tests: editing/text-iterator/backwards-text-iterator-basic.html fast/dom/Range/range-expand.html accessibility/mac/text-marker-sentence-nav.html Created attachment 366880 [details]
Archive of layout-test-results from ews116 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 366876 [details] Fixes the bug Attachment 366876 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11789045 New failing tests: editing/text-iterator/backwards-text-iterator-basic.html Created attachment 366881 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 366876 [details] Fixes the bug Attachment 366876 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11789177 New failing tests: fast/dom/Range/range-expand.html Created attachment 366882 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 367030 [details]
WIP
The previous patch revealed a bug in startOfSentence. When I fix that, AXObjectCache::previousBoundary in turn reveals another bug about the way we're failing to take care of suffixLength affecting the text index within a text node.
So I'd have to fix 3-4 unrelated bugs that used to cancel one another before this patch at once :(
Created attachment 367084 [details]
Fixes the bug
Comment on attachment 367084 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=367084&action=review > Source/WebCore/editing/TextIterator.h:53 > +// For testing. > +WEBCORE_EXPORT String plainTextUsingBackwardsTextIterator(const Range&); I didn't look at the rest of the patch, but this caught my eye. Why not add "ForTesting" to the function name? (In reply to Alexey Proskuryakov from comment #15) > Comment on attachment 367084 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367084&action=review > > > Source/WebCore/editing/TextIterator.h:53 > > +// For testing. > > +WEBCORE_EXPORT String plainTextUsingBackwardsTextIterator(const Range&); > > I didn't look at the rest of the patch, but this caught my eye. Why not add > "ForTesting" to the function name? Sure, I can add that suffix. Created attachment 367203 [details]
Added ForTesting suffix to plainTextUsingBackwardsTextIterator
Comment on attachment 367203 [details] Added ForTesting suffix to plainTextUsingBackwardsTextIterator View in context: https://bugs.webkit.org/attachment.cgi?id=367203&action=review > Source/WebCore/ChangeLog:17 > + make SimplifiedBackwardsTextIterator directly testable in layout tests. Nit - s/make/to make/ Committed r244200: <https://trac.webkit.org/changeset/244200> |