Bug 196669

Summary: Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Web Template FrameworkAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, dbates, ews-watchlist, ggaren, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add tests
none
Patch for landing none

Ryosuke Niwa
Reported 2019-04-05 20:46:58 PDT
Add some tests.
Attachments
Add tests (12.25 KB, patch)
2019-04-05 20:51 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.03 KB, patch)
2019-04-06 16:48 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-04-05 20:51:39 PDT
Created attachment 366872 [details] Add tests
Geoffrey Garen
Comment 2 2019-04-05 21:09:10 PDT
Comment on attachment 366872 [details] Add tests r=me
Ryosuke Niwa
Comment 3 2019-04-05 23:06:40 PDT
Hm... TestWTF.WTF_WeakPtr.WeakHashSetComputeSize is timing out on iOS?
Ryosuke Niwa
Comment 4 2019-04-06 16:03:04 PDT
Comment on attachment 366872 [details] Add tests View in context: https://bugs.webkit.org/attachment.cgi?id=366872&action=review > Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:746 > + } while (weakHashSet.begin().get() != firstObject.get()); Oh oops, this isn't gonna work... Gotta loop over the whole thing.
Ryosuke Niwa
Comment 5 2019-04-06 16:48:14 PDT
Created attachment 366894 [details] Patch for landing
Ryosuke Niwa
Comment 6 2019-04-06 16:48:28 PDT
Comment on attachment 366894 [details] Patch for landing Wait for EWS...
Ryosuke Niwa
Comment 7 2019-04-06 20:56:01 PDT
Comment on attachment 366894 [details] Patch for landing Clearing flags on attachment: 366894 Committed r243965: <https://trac.webkit.org/changeset/243965>
Ryosuke Niwa
Comment 8 2019-04-06 20:56:03 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-04-06 20:57:15 PDT
<rdar://problem/49675200>
Note You need to log in before you can comment on or make changes to this bug.