Bug 196669

Summary: Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Web Template FrameworkAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, dbates, ews-watchlist, ggaren, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add tests
none
Patch for landing none

Description Ryosuke Niwa 2019-04-05 20:46:58 PDT 
Add some tests.
Comment 1 Ryosuke Niwa 2019-04-05 20:51:39 PDT 
Created attachment 366872 [details]
Add tests
Comment 2 Geoffrey Garen 2019-04-05 21:09:10 PDT 
Comment on attachment 366872 [details]
Add tests

r=me
Comment 3 Ryosuke Niwa 2019-04-05 23:06:40 PDT 
Hm... TestWTF.WTF_WeakPtr.WeakHashSetComputeSize is timing out on iOS?
Comment 4 Ryosuke Niwa 2019-04-06 16:03:04 PDT 
Comment on attachment 366872 [details]
Add tests

View in context: https://bugs.webkit.org/attachment.cgi?id=366872&action=review

> Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:746
> +        } while (weakHashSet.begin().get() != firstObject.get());

Oh oops, this isn't gonna work... Gotta loop over the whole thing.
Comment 5 Ryosuke Niwa 2019-04-06 16:48:14 PDT 
Created attachment 366894 [details]
Patch for landing
Comment 6 Ryosuke Niwa 2019-04-06 16:48:28 PDT 
Comment on attachment 366894 [details]
Patch for landing

Wait for EWS...
Comment 7 Ryosuke Niwa 2019-04-06 20:56:01 PDT 
Comment on attachment 366894 [details]
Patch for landing

Clearing flags on attachment: 366894

Committed r243965: <https://trac.webkit.org/changeset/243965>
Comment 8 Ryosuke Niwa 2019-04-06 20:56:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-04-06 20:57:15 PDT 
<rdar://problem/49675200>