Bug 196618 – [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Aakash Jain]

In the new EWS, we have separated builders and testers. A build is done by a builder queue, and then it triggers the tester queue. 

While a patch is waiting in the testers queue (e.g.: api-mac), instead of showing 'waiting in queue', the status-bubble for 'api-mac' should display the build information from the corresponding builder queue 'mac'. For e.g.: while the patch is waiting on api-mac queue, it's status-bubble should show the information from 'mac' queue. It would let the user know that the patch has been compiled successfully and is waiting for API tests, or the patch failed to compile (and so API tests won't be run on it).

[Aakash Jain]

Created attachment 366738 [details]
Patch

[Lucas Forschler]

Comment on attachment 366738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366738&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:155
> +            return (None, None)

would it make sense to re-arrange this if statement above the other? then you don't need to check for 'builds' twice.  So it would read like:

if not builds:
    return (None, None)
if parent_queue:
    builds = self.get_builds_for_queue(patch, parent_queue)
    is_parent_build = True

[Aakash Jain]

Comment on attachment 366738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366738&action=review

>> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:155
>> +            return (None, None)
> 
> would it make sense to re-arrange this if statement above the other? then you don't need to check for 'builds' twice.  So it would read like:
> 
> if not builds:
>     return (None, None)
> if parent_queue:
>     builds = self.get_builds_for_queue(patch, parent_queue)
>     is_parent_build = True

That would change the logic and parent_queue would never be checked.

The logic I want to implement is:
- get_builds_for_queue 'api-mac'
- if no builds found and parent_queue is passed, then get_builds_for_queue parent (e.g.: mac)
- if parent queue also doesn't have any build, then return None
- if builds found in any of above step, use that

[WebKit Commit Bot]

Comment on attachment 366738 [details]
Patch

Clearing flags on attachment: 366738

Committed r243914: <https://trac.webkit.org/changeset/243914>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49626216>