Bug 196585

Summary: Service Worker Process does not have the right domain name
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=197983
Attachments:
Description Flags
Patch
none
Patch for landing none

Description youenn fablet 2019-04-03 18:07:38 PDT
Service Worker Process does not have the right domain name.
(nullOrigin) is displayed currently.
Comment 1 youenn fablet 2019-04-03 18:09:45 PDT
<rdar://problem/46142264>
Comment 2 youenn fablet 2019-04-03 18:10:31 PDT
Created attachment 366684 [details]
Patch
Comment 3 Chris Dumez 2019-04-03 21:05:33 PDT
Comment on attachment 366684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366684&action=review

> Source/WebKit/ChangeLog:10
> +        Updated extraInitializationData to go from "security-origin" to "registrabble-domain".

typo: registrabble-domain
Comment 4 youenn fablet 2019-04-04 08:45:00 PDT
Created attachment 366716 [details]
Patch for landing
Comment 5 youenn fablet 2019-04-04 10:18:17 PDT
I'll try to add a test for it, probably we can get this information from UIProcess/testRunner or directly in an API test.
Comment 6 WebKit Commit Bot 2019-04-04 10:44:22 PDT
Comment on attachment 366716 [details]
Patch for landing

Clearing flags on attachment: 366716

Committed r243880: <https://trac.webkit.org/changeset/243880>
Comment 7 WebKit Commit Bot 2019-04-04 10:44:23 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Chris Dumez 2019-04-04 10:46:13 PDT
(In reply to youenn fablet from comment #5)
> I'll try to add a test for it, probably we can get this information from
> UIProcess/testRunner or directly in an API test.

I did something a bit similar in ProcessSwap.SuspendedPagesInActivityMonitor.