Bug 196583

Summary:

TestWebKitAPI config.h should be aware of what suite is being built

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

Tools / Tests

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, annulen, aperez, cgarcia, commit-queue, ews-watchlist, lforschler, mcatanzaro

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
Patch	annulen: review+
Patch	none

Don Olmstead

Reported 2019-04-03 17:22:56 PDT

Currently all tests have a dependency on each library's export macros due to includes in the config.h. Proposing we add -DBUILDING_TEST<Target> to the compile options to cut down on what is being built.

Attachments
WIP Patch (44.48 KB, patch) 2019-04-29 13:03 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (44.92 KB, patch) 2019-04-29 13:06 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (45.42 KB, patch) 2019-04-29 14:06 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (47.75 KB, patch) 2019-04-29 14:27 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (48.67 KB, patch) 2019-04-29 14:50 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (48.90 KB, patch) 2019-04-29 14:59 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (48.93 KB, patch) 2019-04-29 15:17 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (49.00 KB, patch) 2019-04-29 15:26 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (50.33 KB, patch) 2019-04-29 15:51 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (50.00 KB, patch) 2019-04-29 15:54 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (50.02 KB, patch) 2019-04-29 16:13 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (50.31 KB, patch) 2019-04-29 16:22 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (56.07 KB, patch) 2019-04-29 16:47 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (56.73 KB, patch) 2019-04-30 09:19 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (57.68 KB, patch) 2019-04-30 13:57 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (57.83 KB, patch) 2019-04-30 14:43 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (58.03 KB, patch) 2019-04-30 16:40 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (58.23 KB, patch) 2019-04-30 18:28 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (59.94 KB, patch) 2019-05-01 09:46 PDT, Don Olmstead	annulen: review+	Details Formatted Diff Diff
Patch (59.94 KB, patch) 2019-05-01 16:07 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Show Obsolete (19) View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2019-04-29 13:03:06 PDT Comment hidden (obsolete)

Created attachment 368476 [details] WIP Patch Just seeing how bots do

EWS Watchlist

Comment 2 2019-04-29 13:06:06 PDT Comment hidden (obsolete)

Attachment 368476 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:51: "WebKit/WebKit2_C.h" already included at Tools/TestWebKitAPI/config.h:39 [build/include] [4] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:38: Alphabetical sorting problem. "Tests/WTF/glib/GUniquePtr.cpp" should be before "glib/UtilitiesGLib.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:46: Alphabetical sorting problem. "Tests/WebCore/gstreamer/GstMappedBuffer.cpp" should be before "glib/UtilitiesGLib.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:47: Alphabetical sorting problem. "Tests/WebCore/gstreamer/GStreamerTest.cpp" should be before "Tests/WebCore/gstreamer/GstMappedBuffer.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:54: There should be exactly one empty line instead of 0 between "glib/UtilitiesGLib.cpp" and "wpe/PlatformUtilitiesWPE.cpp". [list/emptyline] [5] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:56: There should be exactly one empty line instead of 0 between "wpe/PlatformWebViewWPE.cpp" and "wpe/backends/ViewBackend.cpp". [list/emptyline] [5] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:57: Alphabetical sorting problem. "wpe/backends/HeadlessViewBackend.cpp" should be before "wpe/backends/ViewBackend.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:23: No space between command "endmacro" and its parentheses, should be "endmacro(" [whitespace/parentheses] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:29: There should be exactly one empty line instead of 0 between "TestsController.cpp" and "Tests/WTF/AtomicString.cpp". [list/emptyline] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:64: Alphabetical sorting problem. "Tests/WTF/OptionSet.cpp" should be before "Tests/WTF/Optional.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:122: There should be exactly one empty line instead of 0 between "TestsController.cpp" and "Tests/WebCore/AffineTransform.cpp". [list/emptyline] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:125: Alphabetical sorting problem. "Tests/WebCore/CSSParser.cpp" should be before "Tests/WebCore/ComplexTextController.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:128: Alphabetical sorting problem. "Tests/WebCore/FloatPoint.cpp" should be before "Tests/WebCore/FloatRect.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:133: Alphabetical sorting problem. "Tests/WebCore/IntPoint.cpp" should be before "Tests/WebCore/IntRect.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:200: Alphabetical sorting problem. "Tests/WebKit/DOMWindowExtensionBasic.cpp" should be before "Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:239: Alphabetical sorting problem. "Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp" should be before "Tests/WebKit/WillSendSubmitEvent.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:269: Alphabetical sorting problem. "NetworkProcess" should be before "WebProcess". [list/order] [5] ERROR: Tools/TestWebKitAPI/PlatformWin.cmake:34: Alphabetical sorting problem. "Tests/WebCore/win/DIBPixelData.cpp" should be before "win/TestWebCoreStubs.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/PlatformWin.cmake:62: There should be exactly one empty line instead of 0 between "Tests/WebCore/CryptoDigest.cpp" and "Tests/WebCore/curl/Cookies.cpp". [list/emptyline] [5] ERROR: Tools/TestWebKitAPI/PlatformWin.cmake:63: There should be exactly one empty line instead of 0 between "Tests/WebCore/curl/Cookies.cpp" and "Tests/WebCore/win/BitmapImage.cpp". [list/emptyline] [5] ERROR: Tools/TestWebKitAPI/PlatformWin.cmake:99: There should be exactly one empty line instead of 0 between "Tests/WebKitLegacy/win/WebViewDestruction.cpp" and "win/HostWindow.cpp". [list/emptyline] [5] Total errors found: 21 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 3 2019-04-29 13:06:16 PDT Comment hidden (obsolete)

Created attachment 368478 [details] WIP Patch

EWS Watchlist

Comment 4 2019-04-29 13:08:18 PDT Comment hidden (obsolete)

Attachment 368478 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:51: "WebKit/WebKit2_C.h" already included at Tools/TestWebKitAPI/config.h:39 [build/include] [4] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:38: Alphabetical sorting problem. "Tests/WTF/glib/GUniquePtr.cpp" should be before "glib/UtilitiesGLib.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:46: Alphabetical sorting problem. "Tests/WebCore/gstreamer/GstMappedBuffer.cpp" should be before "glib/UtilitiesGLib.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:47: Alphabetical sorting problem. "Tests/WebCore/gstreamer/GStreamerTest.cpp" should be before "Tests/WebCore/gstreamer/GstMappedBuffer.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:54: There should be exactly one empty line instead of 0 between "glib/UtilitiesGLib.cpp" and "wpe/PlatformUtilitiesWPE.cpp". [list/emptyline] [5] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:56: There should be exactly one empty line instead of 0 between "wpe/PlatformWebViewWPE.cpp" and "wpe/backends/ViewBackend.cpp". [list/emptyline] [5] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:57: Alphabetical sorting problem. "wpe/backends/HeadlessViewBackend.cpp" should be before "wpe/backends/ViewBackend.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:23: No space between command "endmacro" and its parentheses, should be "endmacro(" [whitespace/parentheses] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:29: There should be exactly one empty line instead of 0 between "TestsController.cpp" and "Tests/WTF/AtomicString.cpp". [list/emptyline] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:64: Alphabetical sorting problem. "Tests/WTF/OptionSet.cpp" should be before "Tests/WTF/Optional.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:122: There should be exactly one empty line instead of 0 between "TestsController.cpp" and "Tests/WebCore/AffineTransform.cpp". [list/emptyline] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:125: Alphabetical sorting problem. "Tests/WebCore/CSSParser.cpp" should be before "Tests/WebCore/ComplexTextController.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:128: Alphabetical sorting problem. "Tests/WebCore/FloatPoint.cpp" should be before "Tests/WebCore/FloatRect.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:133: Alphabetical sorting problem. "Tests/WebCore/IntPoint.cpp" should be before "Tests/WebCore/IntRect.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:200: Alphabetical sorting problem. "Tests/WebKit/DOMWindowExtensionBasic.cpp" should be before "Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:239: Alphabetical sorting problem. "Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp" should be before "Tests/WebKit/WillSendSubmitEvent.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:269: Alphabetical sorting problem. "NetworkProcess" should be before "WebProcess". [list/order] [5] ERROR: Tools/TestWebKitAPI/PlatformWin.cmake:34: Alphabetical sorting problem. "Tests/WebCore/win/DIBPixelData.cpp" should be before "win/TestWebCoreStubs.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/PlatformWin.cmake:62: There should be exactly one empty line instead of 0 between "Tests/WebCore/CryptoDigest.cpp" and "Tests/WebCore/curl/Cookies.cpp". [list/emptyline] [5] ERROR: Tools/TestWebKitAPI/PlatformWin.cmake:63: There should be exactly one empty line instead of 0 between "Tests/WebCore/curl/Cookies.cpp" and "Tests/WebCore/win/BitmapImage.cpp". [list/emptyline] [5] ERROR: Tools/TestWebKitAPI/PlatformWin.cmake:99: There should be exactly one empty line instead of 0 between "Tests/WebKitLegacy/win/WebViewDestruction.cpp" and "win/HostWindow.cpp". [list/emptyline] [5] Total errors found: 21 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 5 2019-04-29 14:06:34 PDT Comment hidden (obsolete)

Created attachment 368491 [details] WIP Patch

EWS Watchlist

Comment 6 2019-04-29 14:08:27 PDT Comment hidden (obsolete)

Attachment 368491 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:51: "WebKit/WebKit2_C.h" already included at Tools/TestWebKitAPI/config.h:39 [build/include] [4] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:49: Alphabetical sorting problem. "Tests/WebCore/gstreamer/GStreamerTest.cpp" should be before "Tests/WebCore/gstreamer/GstMappedBuffer.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:126: Alphabetical sorting problem. "Tests/WebCore/CSSParser.cpp" should be before "Tests/WebCore/CalculationValue.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:135: Alphabetical sorting problem. "Tests/WebCore/IntPoint.cpp" should be before "Tests/WebCore/IntRect.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/PlatformWin.cmake:66: No trailing spaces [whitespace/trailing] [5] ERROR: Tools/TestWebKitAPI/PlatformWin.cmake:104: No trailing spaces [whitespace/trailing] [5] Total errors found: 6 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 7 2019-04-29 14:27:35 PDT Comment hidden (obsolete)

Created attachment 368493 [details] WIP Patch

EWS Watchlist

Comment 8 2019-04-29 14:29:53 PDT Comment hidden (obsolete)

Attachment 368493 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:51: "WebKit/WebKit2_C.h" already included at Tools/TestWebKitAPI/config.h:39 [build/include] [4] ERROR: Tools/TestWebKitAPI/Tests/WebCore/LineBreaking.mm:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:126: Alphabetical sorting problem. "Tests/WebCore/CSSParser.cpp" should be before "Tests/WebCore/CalculationValue.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/CMakeLists.txt:135: Alphabetical sorting problem. "Tests/WebCore/IntPoint.cpp" should be before "Tests/WebCore/IntRect.cpp". [list/order] [5] ERROR: Tools/TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 5 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 9 2019-04-29 14:50:01 PDT Comment hidden (obsolete)

Created attachment 368495 [details] WIP Patch

EWS Watchlist

Comment 10 2019-04-29 14:51:47 PDT Comment hidden (obsolete)

Attachment 368495 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:49: "WebKit/WebKit2_C.h" already included at Tools/TestWebKitAPI/config.h:39 [build/include] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 11 2019-04-29 14:59:49 PDT Comment hidden (obsolete)

Created attachment 368497 [details] WIP Patch

EWS Watchlist

Comment 12 2019-04-29 15:00:55 PDT Comment hidden (obsolete)

Attachment 368497 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:57: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:58: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:47 [build/include] [4] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 13 2019-04-29 15:17:33 PDT Comment hidden (obsolete)

Created attachment 368499 [details] WIP Patch

EWS Watchlist

Comment 14 2019-04-29 15:20:17 PDT Comment hidden (obsolete)

Attachment 368499 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:57: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:58: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:47 [build/include] [4] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 15 2019-04-29 15:26:01 PDT Comment hidden (obsolete)

Created attachment 368500 [details] WIP Patch

EWS Watchlist

Comment 16 2019-04-29 15:27:57 PDT Comment hidden (obsolete)

Attachment 368500 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:57: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:58: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:47 [build/include] [4] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 17 2019-04-29 15:51:24 PDT Comment hidden (obsolete)

Created attachment 368504 [details] WIP Patch

Don Olmstead

Comment 18 2019-04-29 15:54:29 PDT Comment hidden (obsolete)

Created attachment 368506 [details] WIP Patch

EWS Watchlist

Comment 19 2019-04-29 15:57:41 PDT Comment hidden (obsolete)

Attachment 368506 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:59: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:60: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:49 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:61: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:50 [build/include] [4] Total errors found: 3 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 20 2019-04-29 16:13:35 PDT Comment hidden (obsolete)

Created attachment 368507 [details] WIP Patch

EWS Watchlist

Comment 21 2019-04-29 16:15:56 PDT Comment hidden (obsolete)

Attachment 368507 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:59: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:60: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:49 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:61: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:50 [build/include] [4] Total errors found: 3 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 22 2019-04-29 16:22:27 PDT Comment hidden (obsolete)

Created attachment 368510 [details] WIP Patch

EWS Watchlist

Comment 23 2019-04-29 16:25:54 PDT Comment hidden (obsolete)

Attachment 368510 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:49: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:60: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:61: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:50 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:62: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:51 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:64: "WebKit/WebKit2_C.h" already included at Tools/TestWebKitAPI/config.h:54 [build/include] [4] Total errors found: 5 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 24 2019-04-29 16:47:57 PDT Comment hidden (obsolete)

Created attachment 368514 [details] WIP Patch

EWS Watchlist

Comment 25 2019-04-29 16:49:39 PDT Comment hidden (obsolete)

Attachment 368514 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:49: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:60: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:61: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:50 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:62: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:51 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:64: "WebKit/WebKit2_C.h" already included at Tools/TestWebKitAPI/config.h:54 [build/include] [4] ERROR: Tools/TestWebKitAPI/PlatformGTK.cmake:71: No trailing spaces [whitespace/trailing] [5] Total errors found: 6 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 26 2019-04-30 09:19:16 PDT Comment hidden (obsolete)

Created attachment 368572 [details] WIP Patch

EWS Watchlist

Comment 27 2019-04-30 09:23:25 PDT Comment hidden (obsolete)

Attachment 368572 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:50: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:56: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:57: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:51 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:58: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:52 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:58: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/TestWebKitAPI/config.h:65: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:66: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:51 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:67: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:52 [build/include] [4] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:67: No trailing spaces [whitespace/trailing] [5] ERROR: Tools/TestWebKitAPI/PlatformGTK.cmake:71: No trailing spaces [whitespace/trailing] [5] Total errors found: 10 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Konstantin Tokarev

Comment 28 2019-04-30 12:20:13 PDT

Comment on attachment 368572 [details] WIP Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368572&action=review > Tools/TestWebKitAPI/CMakeLists.txt:4 > +add_definitions(${gtest_DEFINITIONS}) We should not use add_definitions(). Instead, gtest target should have PUBLIC (or INTERFACE) definitions, which will be used automatically for any target where gtest is linked > Tools/TestWebKitAPI/PlatformWin.cmake:10 > +add_definitions(-DSTATICALLY_LINKED_WITH_PAL=1) Use target_compile_definitions() (or COMPILE_DEFINITIONS property) instead of deprecated add_definitions()

Don Olmstead

Comment 29 2019-04-30 13:57:38 PDT Comment hidden (obsolete)

Created attachment 368606 [details] WIP Patch

EWS Watchlist

Comment 30 2019-04-30 14:00:07 PDT Comment hidden (obsolete)

Attachment 368606 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:50: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:56: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:57: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:51 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:58: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:52 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:58: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/TestWebKitAPI/config.h:65: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:66: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:51 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:67: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:52 [build/include] [4] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:58: No trailing spaces [whitespace/trailing] [5] ERROR: Tools/TestWebKitAPI/PlatformGTK.cmake:52: No trailing spaces [whitespace/trailing] [5] ERROR: Tools/TestWebKitAPI/PlatformWin.cmake:12: Alphabetical sorting problem. "STATICALLY_LINKED_WITH_PAL" should be before "WEBCORE_TESTSUPPORT_EXPORT". [list/order] [5] Total errors found: 11 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 31 2019-04-30 14:43:57 PDT Comment hidden (obsolete)

Created attachment 368616 [details] WIP Patch

EWS Watchlist

Comment 32 2019-04-30 14:46:06 PDT Comment hidden (obsolete)

Attachment 368616 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:50: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:56: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:57: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:51 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:58: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:52 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:58: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/TestWebKitAPI/config.h:65: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:66: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:51 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:67: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:52 [build/include] [4] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:80: No trailing spaces [whitespace/trailing] [5] ERROR: Tools/TestWebKitAPI/PlatformGTK.cmake:52: No trailing spaces [whitespace/trailing] [5] ERROR: Tools/TestWebKitAPI/PlatformWin.cmake:12: Alphabetical sorting problem. "STATICALLY_LINKED_WITH_PAL" should be before "WEBCORE_TESTSUPPORT_EXPORT". [list/order] [5] Total errors found: 11 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 33 2019-04-30 15:21:24 PDT

(In reply to Konstantin Tokarev from comment #28) > Comment on attachment 368572 [details] > WIP Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=368572&action=review > > > Tools/TestWebKitAPI/CMakeLists.txt:4 > > +add_definitions(${gtest_DEFINITIONS}) > > We should not use add_definitions(). Instead, gtest target should have > PUBLIC (or INTERFACE) definitions, which will be used automatically for any > target where gtest is linked I feel that should be a separate task after this lands.

Konstantin Tokarev

Comment 34 2019-04-30 15:23:10 PDT

Don Olmstead

Comment 35 2019-04-30 16:40:24 PDT Comment hidden (obsolete)

Created attachment 368629 [details] WIP Patch

EWS Watchlist

Comment 36 2019-04-30 16:43:43 PDT Comment hidden (obsolete)

Attachment 368629 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:50: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:56: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:57: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:51 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:58: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:52 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:58: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/TestWebKitAPI/config.h:65: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:66: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:51 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:67: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:52 [build/include] [4] ERROR: Tools/TestWebKitAPI/PlatformWPE.cmake:80: No trailing spaces [whitespace/trailing] [5] ERROR: Tools/TestWebKitAPI/PlatformGTK.cmake:60: No trailing spaces [whitespace/trailing] [5] ERROR: Tools/TestWebKitAPI/PlatformWin.cmake:12: Alphabetical sorting problem. "STATICALLY_LINKED_WITH_PAL" should be before "WEBCORE_TESTSUPPORT_EXPORT". [list/order] [5] Total errors found: 11 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 37 2019-04-30 18:28:04 PDT

Created attachment 368641 [details] WIP Patch Think all bots will be happy after this.

EWS Watchlist

Comment 38 2019-04-30 18:30:37 PDT Comment hidden (obsolete)

Attachment 368641 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:50: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:56: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:57: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:51 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:58: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:52 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:58: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/TestWebKitAPI/config.h:65: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:66: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:51 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:67: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:52 [build/include] [4] ERROR: Tools/TestWebKitAPI/PlatformGTK.cmake:62: No trailing spaces [whitespace/trailing] [5] Total errors found: 9 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Don Olmstead

Comment 39 2019-04-30 18:35:38 PDT

Adding some Igalia folks since to make sure that we aren't breaking their test runs. Build should be working now but I haven't run tests on anything. Can you folks make sure that the tests are running as expected?

Michael Catanzaro

Comment 40 2019-05-01 07:22:43 PDT

Beware today is a holiday. I would just land it and watch https://build.webkit.org/dashboard/

Don Olmstead

Comment 41 2019-05-01 09:46:46 PDT

Created attachment 368679 [details] Patch Think this is ready for a review.

EWS Watchlist

Comment 42 2019-05-01 09:48:58 PDT

Attachment 368679 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/config.h:50: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:56: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:57: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:51 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:58: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:52 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:58: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/TestWebKitAPI/config.h:65: "JavaScriptCore/JSExportMacros.h" already included at Tools/TestWebKitAPI/config.h:46 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:66: "WebCore/PlatformExportMacros.h" already included at Tools/TestWebKitAPI/config.h:51 [build/include] [4] ERROR: Tools/TestWebKitAPI/config.h:67: "pal/ExportMacros.h" already included at Tools/TestWebKitAPI/config.h:52 [build/include] [4] Total errors found: 8 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

Konstantin Tokarev

Comment 43 2019-05-01 14:49:32 PDT

Comment on attachment 368679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368679&action=review > Tools/TestWebKitAPI/PlatformGTK.cmake:110 > + ${FORWARDING_HEADERS_DIR} Looks like something we wanted to get rid off, doesn't it?

Don Olmstead

Comment 44 2019-05-01 14:53:03 PDT

(In reply to Konstantin Tokarev from comment #43) > Comment on attachment 368679 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=368679&action=review > > > Tools/TestWebKitAPI/PlatformGTK.cmake:110 > > + ${FORWARDING_HEADERS_DIR} > > Looks like something we wanted to get rid off, doesn't it? Windows is copying all its headers around. GTK and WPE still have the forwarding headers being generated for WebKit and some other testing stuff. I just want to leave this alone for the moment until I get WebKit fully copying headers.

Konstantin Tokarev

Comment 45 2019-05-01 14:59:19 PDT

Comment on attachment 368679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368679&action=review LGTM except that letter case error > Tools/TestWebKitAPI/PlatformWin.cmake:98 > +set(TestWebcore_OUTPUT_NAME TestWebCore${DEBUG_SUFFIX}) Wrong letter case in TestWebcore_OUTPUT_NAME

Don Olmstead

Comment 46 2019-05-01 16:07:57 PDT

Created attachment 368726 [details] Patch

WebKit Commit Bot

Comment 47 2019-05-01 16:47:34 PDT

Comment on attachment 368726 [details] Patch Clearing flags on attachment: 368726 Committed r244857: <https://trac.webkit.org/changeset/244857>

WebKit Commit Bot

Comment 48 2019-05-01 16:47:36 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 49 2019-05-02 15:33:38 PDT

<rdar://problem/50424785>

Note You need to log in before you can comment on or make changes to this bug.