Bug 196581

Summary:

[ews-build] Do not trigger queues which are not in production yet

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, dewei_zhu, ews-watchlist, jbedard, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews201 for win-future	none

Aakash Jain

Reported 2019-04-03 17:10:03 PDT

We should not trigger queues which are not in production yet (without any bots attached). It would result in large list of pending build-requests on those queues and make Buildbot inefficient.

Attachments
Patch (2.60 KB, patch) 2019-04-03 17:11 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews201 for win-future (13.74 MB, application/zip) 2019-04-03 18:46 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-04-03 17:11:25 PDT

Created attachment 366675 [details] Patch

EWS Watchlist

Comment 2 2019-04-03 18:46:19 PDT Comment hidden (obsolete)

Comment on attachment 366675 [details] Patch Attachment 366675 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11758988 New failing tests: fast/multicol/body-stuck-with-dirty-bit-with-columns.html fast/multicol/client-rects.html fast/multicol/assert-with-nested-columns-and-spanner.html fast/multicol/break-in-scrollable.html fast/multicol/clone-block-children-inline-mismatch-crash.html fast/multicol/block-axis-vertical-rl.html fast/multicol/assert-on-continuation-with-spanner.html fast/multicol/block-axis-vertical-lr.html fast/multicol/assert-on-small-page-height-with-widow.html fast/multicol/client-rects-spanners.html fast/multicol/block-axis-horizontal-bt.html fast/multicol/border-radius-overflow-columns.html fast/multicol/clip-in-columns.html fast/multicol/break-in-columns-before-spanner.html fast/multicol/block-axis-horizontal-tb.html fast/multicol/break-after-always-bottom-margin.html fast/multicol/cell-shrinkback.html fast/multicol/border-padding-pagination.html fast/multicol/break-properties.html fast/multicol/client-rects-spanners-complex.html

EWS Watchlist

Comment 3 2019-04-03 18:46:22 PDT Comment hidden (obsolete)

Created attachment 366689 [details] Archive of layout-test-results from ews201 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews201 Port: win-future Platform: CYGWIN_NT-10.0-2.11.1-0.329-5-3-x86_64-64bit

WebKit Commit Bot

Comment 4 2019-04-03 20:38:07 PDT

Comment on attachment 366675 [details] Patch Clearing flags on attachment: 366675 Committed r243852: <https://trac.webkit.org/changeset/243852>

WebKit Commit Bot

Comment 5 2019-04-03 20:38:08 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2019-04-03 20:39:22 PDT

<rdar://problem/49590161>

Jonathan Bedard

Comment 7 2019-04-04 09:02:51 PDT

Comment on attachment 366675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366675&action=review > Tools/BuildSlaveSupport/ews-build/config.json:-304 > - "triggers": ["api-tests-ios-sim-ews", "ios-12-sim-wk2-tests-ews"], When will we be bringing these queues into production?

Note You need to log in before you can comment on or make changes to this bug.