Bug 196567 – [Win] DumpRenderTreeWatchDog.py is not checked into source

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Per Arne Vollan]

This script should be checked in. Tools/EWSTools is possibly an appropriate location for it.

[Per Arne Vollan]

rdar://problem/49525901

[Per Arne Vollan]

Created attachment 366654 [details]
Patch

[Lucas Forschler]

Comment on attachment 366654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366654&action=review

> Tools/EWSTools/dumprendertreewatchdog.py:29
> +

these should be alphabetized

> Tools/EWSTools/dumprendertreewatchdog.py:37
> +    proc_fetch = subprocess.Popen("ps -e | grep \"DumpRenderTree\" | awk '{print $1}'", shell=True, stdout=subprocess.PIPE,)

I think this will also capture the ps process itself, right? On my machine with no DumpRenderTree processes running, this command will always return one pid, itself.

> Tools/EWSTools/dumprendertreewatchdog.py:47
> +        # If the active and current PID are the and an hour has elapsed, kill DumpRenderTree and reset the active PID to 0

I think this comment is missing a word between "the" and "and"

[Lucas Forschler]

Comment on attachment 366654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366654&action=review

>> Tools/EWSTools/dumprendertreewatchdog.py:37
>> +    proc_fetch = subprocess.Popen("ps -e | grep \"DumpRenderTree\" | awk '{print $1}'", shell=True, stdout=subprocess.PIPE,)
> 
> I think this will also capture the ps process itself, right? On my machine with no DumpRenderTree processes running, this command will always return one pid, itself.

Also, would this be better named pid_fetch?

(I just tested on Windows and it appears the functionality of ps does not output the ps process itself... so maybe this is ok)

[Per Arne Vollan]

Created attachment 366673 [details]
Patch

[Per Arne Vollan]

(In reply to Lucas Forschler from comment #4)
> Comment on attachment 366654 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=366654&action=review
> 
> >> Tools/EWSTools/dumprendertreewatchdog.py:37
> >> +    proc_fetch = subprocess.Popen("ps -e | grep \"DumpRenderTree\" | awk '{print $1}'", shell=True, stdout=subprocess.PIPE,)
> > 
> > I think this will also capture the ps process itself, right? On my machine with no DumpRenderTree processes running, this command will always return one pid, itself.
> 
> Also, would this be better named pid_fetch?
> 
> (I just tested on Windows and it appears the functionality of ps does not
> output the ps process itself... so maybe this is ok)

Thanks for reviewing! I have updated the patch.

[WebKit Commit Bot]

Comment on attachment 366673 [details]
Patch

Clearing flags on attachment: 366673

Committed r243879: <https://trac.webkit.org/changeset/243879>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.