Bug 196566

Summary: Avoid the use of WTF_EXTERN_C_BEGIN in NSMenuSPI.h
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Remove Extern C around NSMenu_Private.h timothy: review+

Ryosuke Niwa
Reported 2019-04-03 14:49:08 PDT
Avoid the use of WTF_EXTERN_C_BEGIN in NSMenuSPI.h
Attachments
Remove Extern C around NSMenu_Private.h (1.06 KB, patch)
2019-04-03 14:49 PDT, Ryosuke Niwa 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-04-03 14:49:30 PDT
Created attachment 366647 [details] Remove Extern C around NSMenu_Private.h
EWS Watchlist
Comment 2 2019-04-03 14:51:39 PDT
Attachment 366647 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/mac/NSMenuSPI.h:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 3 2019-04-03 15:16:59 PDT
Committed r243831: <https://trac.webkit.org/changeset/243831>
Radar WebKit Bug Importer
Comment 4 2019-04-03 15:18:01 PDT
<rdar://problem/49576483>
Note You need to log in before you can comment on or make changes to this bug.