Bug 196566

Summary:

Avoid the use of WTF_EXTERN_C_BEGIN in NSMenuSPI.h

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

New Bugs

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Remove Extern C around NSMenu_Private.h	timothy: review+

Description Ryosuke Niwa 2019-04-03 14:49:08 PDT

Avoid the use of WTF_EXTERN_C_BEGIN in NSMenuSPI.h

Comment 1 Ryosuke Niwa 2019-04-03 14:49:30 PDT

Created attachment 366647 [details]
Remove Extern C around NSMenu_Private.h

Comment 2 EWS Watchlist 2019-04-03 14:51:39 PDT

Attachment 366647 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/mac/NSMenuSPI.h:30:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Ryosuke Niwa 2019-04-03 15:16:59 PDT

Committed r243831: <https://trac.webkit.org/changeset/243831>

Comment 4 Radar WebKit Bug Importer 2019-04-03 15:18:01 PDT

<rdar://problem/49576483>