Bug 196550

Summary: [ews-app] Status bubble should not display certain infrastructure status messages
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, dewei_zhu, jbedard, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=196584
https://bugs.webkit.org/show_bug.cgi?id=201308
https://bugs.webkit.org/show_bug.cgi?id=225076
Attachments:
Description Flags
Patch lforschler: review+

Aakash Jain
Reported 2019-04-03 11:56:31 PDT
[ews-app] Status bubble should not display certain infrastructure status messages, e.g.: There is no need to display 'Killed old processes' or 'Configured build' in the status-bubble hover over message.
Attachments
Patch (2.04 KB, patch)
2019-04-03 12:06 PDT, Aakash Jain 		lforschler: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-04-03 12:06:52 PDT
Created attachment 366627 [details] Patch
Lucas Forschler
Comment 2 2019-04-03 12:58:38 PDT
Comment on attachment 366627 [details] Patch This looks fine to me...but I'm not sure why we need to hide the steps? Can you add more information to change log about why we would want to hide these? Are they ugly? un-needed? does hiding them make it harder to debug?
Aakash Jain
Comment 3 2019-04-03 13:27:15 PDT
Committed r243823: <https://trac.webkit.org/changeset/243823>
Radar WebKit Bug Importer
Comment 4 2019-04-03 13:28:21 PDT
<rdar://problem/49570722>
Aakash Jain
Comment 5 2019-04-03 13:30:17 PDT
> This looks fine to me...but I'm not sure why we need to hide the steps? Can > you add more information to change log about why we would want to hide > these? Are they ugly? un-needed? does hiding them make it harder to debug? Updated ChangeLog before landing. They are simply un-needed from end user perspective. This information is still available in the Buildbot build page, if the user click on the status-bubble.
Note You need to log in before you can comment on or make changes to this bug.