Bug 196538

Summary: [ATK] Wrong index passed to AtkObject::children-changed::add signal in AXObjectCache::attachWrapper()
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, mario, mcatanzaro, samuel_white, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2019-04-03 07:25:57 PDT
In most of the cases the parent is not found, probably because the child is not a direct descendant of the parent returned by parentObjectUnignored(). We need to handle the case of find() returning notFound.
Attachments
Patch (1.66 KB, patch)
2019-04-03 07:27 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-04-03 07:26:16 PDT
<rdar://problem/49557794>
Carlos Garcia Campos
Comment 2 2019-04-03 07:27:54 PDT
Created attachment 366601 [details] Patch
Carlos Garcia Campos
Comment 3 2019-04-03 22:53:36 PDT
Committed r243864: <https://trac.webkit.org/changeset/243864>
Mario Sanchez Prada
Comment 4 2019-04-05 01:43:45 PDT
Returning -1 when the parent is not known seems consistent with the docs at https://developer.gnome.org/atk/stable/AtkObject.html, so another (late) lgtm
Note You need to log in before you can comment on or make changes to this bug.