Bug 196538

Summary:

[ATK] Wrong index passed to AtkObject::children-changed::add signal in AXObjectCache::attachWrapper()

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, mario, mcatanzaro, samuel_white, webkit-bug-importer

Priority:

Keywords:

Gtk, InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mcatanzaro: review+

Description Carlos Garcia Campos 2019-04-03 07:25:57 PDT

In most of the cases the parent is not found, probably because the child is not a direct descendant of the parent returned by parentObjectUnignored(). We need to handle the case of find() returning notFound.

Comment 1 Radar WebKit Bug Importer 2019-04-03 07:26:16 PDT

<rdar://problem/49557794>

Comment 2 Carlos Garcia Campos 2019-04-03 07:27:54 PDT

Created attachment 366601 [details]
Patch

Comment 3 Carlos Garcia Campos 2019-04-03 22:53:36 PDT

Committed r243864: <https://trac.webkit.org/changeset/243864>

Comment 4 Mario Sanchez Prada 2019-04-05 01:43:45 PDT

Returning -1 when the parent is not known seems consistent with the docs at https://developer.gnome.org/atk/stable/AtkObject.html, so another (late) lgtm