Bug 196532

Summary: output element doesn't react properly to node tree mutations
Product: WebKit Reporter: Anne van Kesteren <annevk>
Component: FormsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, cdumez, changseok, clopez, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, kangil.han, kondapallykalyan, mifenton, rniwa, sam, webkit-bug-importer, wenson_hsieh, youennf
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Anne van Kesteren 2019-04-03 03:17:57 PDT
https://github.com/web-platform-tests/wpt/pull/16080 has tests and https://github.com/whatwg/html/pull/4447 has a refactoring of the specification that makes it no longer rely on descendant change notifications.
Comment 1 Ryosuke Niwa 2021-05-13 02:08:40 PDT
Context: https://github.com/whatwg/html/issues/6516
Comment 2 Darin Adler 2021-05-13 10:00:10 PDT
Have we pulled that test in yet? I’d like to look at it; might tackle this bug.
Comment 3 Ryosuke Niwa 2021-05-13 15:55:15 PDT
(In reply to Darin Adler from comment #2)
> Have we pulled that test in yet? I’d like to look at it; might tackle this
> bug.

Yes. It's at LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-output-element/mutations.window.html
Comment 4 Darin Adler 2021-05-13 18:33:57 PDT
Wow, this is easy to fix. I will.
Comment 5 Darin Adler 2021-05-13 18:34:38 PDT
Thank you for making this not be defined in terms of change notifications!
Comment 6 Darin Adler 2021-05-13 20:31:43 PDT Comment hidden (obsolete)
Comment 7 Darin Adler 2021-05-13 20:59:02 PDT Comment hidden (obsolete)
Comment 8 Darin Adler 2021-05-13 21:08:08 PDT Comment hidden (obsolete)
Comment 9 Darin Adler 2021-05-13 21:15:00 PDT Comment hidden (obsolete)
Comment 10 Darin Adler 2021-05-13 23:01:29 PDT Comment hidden (obsolete)
Comment 11 Darin Adler 2021-05-14 09:46:56 PDT
All those EWS bubbles green; hoping for review soon.
Comment 12 Darin Adler 2021-05-14 14:53:02 PDT
Created attachment 428665 [details]
Patch
Comment 13 Darin Adler 2021-05-14 14:53:18 PDT
Good news, the bug in the test was fixed back in March.
Comment 14 EWS Watchlist 2021-05-14 14:53:49 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 15 EWS 2021-05-14 19:05:29 PDT
Committed r277527 (237755@main): <https://commits.webkit.org/237755@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428665 [details].