Bug 196526

Summary:

Add a WebKit internal feature flag to always enable modern compatibility mode by default

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebKit2

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, bdakin, commit-queue, dino, graouts, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	thorton: review+, wenson_hsieh: commit-queue-
Patch for landing	none

Wenson Hsieh

Reported 2019-04-02 22:10:05 PDT

<rdar://problem/49532923>

Attachments
Patch (1.40 KB, patch) 2019-04-03 08:10 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch (2.09 KB, patch) 2019-04-03 14:49 PDT, Wenson Hsieh	thorton: review+ wenson_hsieh: commit-queue-	Details Formatted Diff Diff
Patch for landing (1.99 KB, patch) 2019-04-03 15:38 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2019-04-03 08:10:45 PDT

Created attachment 366604 [details] Patch

WebKit Commit Bot

Comment 2 2019-04-03 09:02:13 PDT

Comment on attachment 366604 [details] Patch Clearing flags on attachment: 366604 Committed r243800: <https://trac.webkit.org/changeset/243800>

WebKit Commit Bot

Comment 3 2019-04-03 09:02:14 PDT

All reviewed patches have been landed. Closing bug.

Wenson Hsieh

Comment 4 2019-04-03 14:35:05 PDT

After hooking this up to internal code, I realized that it actually needs to be in the debug category, as opposed to internal :/

Wenson Hsieh

Comment 5 2019-04-03 14:49:59 PDT

Created attachment 366648 [details] Patch

Tim Horton

Comment 6 2019-04-03 15:24:07 PDT

Comment on attachment 366648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366648&action=review > Source/WebKit/Shared/WebPreferences.yaml:1199 > +UseModernCompatibilityModeByDefault: Is there not a debug section?

Tim Horton

Comment 7 2019-04-03 15:24:43 PDT

Comment on attachment 366648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366648&action=review > Source/WebKit/Shared/WebPreferences.yaml:1203 > + humanReadableDescription: "Use modern compatibility mode everywhere by default" "everywhere" is not a property of the pref, should be left out of the description

Wenson Hsieh

Comment 8 2019-04-03 15:31:44 PDT

Comment on attachment 366648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366648&action=review >> Source/WebKit/Shared/WebPreferences.yaml:1199 >> +UseModernCompatibilityModeByDefault: > > Is there not a debug section? I *think* this is the debug section (the closest comment moving up this place in the file is "# Debug Preferences"). But there are some debug prefs further up that I can put this next to, so I'll move it there. >> Source/WebKit/Shared/WebPreferences.yaml:1203 >> + humanReadableDescription: "Use modern compatibility mode everywhere by default" > > "everywhere" is not a property of the pref, should be left out of the description 👍🏻

Wenson Hsieh

Comment 9 2019-04-03 15:38:08 PDT

Created attachment 366658 [details] Patch for landing

WebKit Commit Bot

Comment 10 2019-04-03 16:29:33 PDT

The commit-queue encountered the following flaky tests while processing attachment 366658 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 11 2019-04-03 16:30:20 PDT

Comment on attachment 366658 [details] Patch for landing Clearing flags on attachment: 366658 Committed r243836: <https://trac.webkit.org/changeset/243836>

Note You need to log in before you can comment on or make changes to this bug.