| Summary: | Add a WebKit internal feature flag to always enable modern compatibility mode by default | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Component: | WebKit2 | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aestes, bdakin, commit-queue, dino, graouts, thorton, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Wenson Hsieh
2019-04-02 22:10:05 PDT
Created attachment 366604 [details]
Patch
Comment on attachment 366604 [details] Patch Clearing flags on attachment: 366604 Committed r243800: <https://trac.webkit.org/changeset/243800> All reviewed patches have been landed. Closing bug. After hooking this up to internal code, I realized that it actually needs to be in the debug category, as opposed to internal :/ Created attachment 366648 [details]
Patch
Comment on attachment 366648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366648&action=review > Source/WebKit/Shared/WebPreferences.yaml:1199 > +UseModernCompatibilityModeByDefault: Is there not a debug section? Comment on attachment 366648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366648&action=review > Source/WebKit/Shared/WebPreferences.yaml:1203 > + humanReadableDescription: "Use modern compatibility mode everywhere by default" "everywhere" is not a property of the pref, should be left out of the description Comment on attachment 366648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366648&action=review >> Source/WebKit/Shared/WebPreferences.yaml:1199 >> +UseModernCompatibilityModeByDefault: > > Is there not a debug section? I *think* this is the debug section (the closest comment moving up this place in the file is "# Debug Preferences"). But there are some debug prefs further up that I can put this next to, so I'll move it there. >> Source/WebKit/Shared/WebPreferences.yaml:1203 >> + humanReadableDescription: "Use modern compatibility mode everywhere by default" > > "everywhere" is not a property of the pref, should be left out of the description 👍🏻 Created attachment 366658 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 366658 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. Comment on attachment 366658 [details] Patch for landing Clearing flags on attachment: 366658 Committed r243836: <https://trac.webkit.org/changeset/243836> |