Bug 196517

Summary:

[ Mac ] REGRESSION (r243033) Assertion failed: m_logger Layout Test imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint.html is a flaky crash

Product:

WebKit

Reporter:

Shawn Roberts <sroberts>

Component:

Tools / Tests

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, lforschler, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=195823

Attachments:

Description	Flags
Patch	none

Shawn Roberts

Reported 2019-04-02 16:57:41 PDT

The following layout test is flaky on Mac Release WK2, Mac Debug WK1 & WK2 imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint.html Probable cause: Test started showing up recently on dashboard as a flaky crash. Through local testing found crashes began with https://trac.webkit.org/changeset/243033/webkit . Testing prior to this revision yield all passes. Crashes the most in WK1 Debug, but I can repro locally in every build listed on the dashboard. Reproduced with: run-webkit-tests imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint.html --iterations 500 -f --debug -1 --exit-after-n-failures=2 Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fmst-content-hint%2FMediaStreamTrack-contentHint.html Crash Log: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r243759%20(2880)/imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint-crash-log.txt ASSERTION FAILED: m_logger /Volumes/Data/slave/mojave-debug/build/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h(121) : virtual const WTF::Logger &WebCore::MediaStreamTrackPrivate::logger() const 1 0x104d9fdb9 WTFCrash 2 0x1139d655b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x116de6b07 WebCore::MediaStreamTrackPrivate::logger() const 4 0x116de6259 WebCore::MediaStreamTrackPrivate::updateReadyState() 5 0x116de6a0e WebCore::MediaStreamTrackPrivate::audioSamplesAvailable(WTF::MediaTime const&, WebCore::PlatformAudioData const&, WebCore::AudioStreamDescription const&, unsigned long)

Attachments
Patch (1.67 KB, patch) 2019-10-14 09:52 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.