Bug 196498

Summary: Align event dispatching logic with Blink and Gecko
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/whatwg/dom/issues/746
Attachments:
Description Flags
WIP Patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews102 for mac-highsierra
none
Archive of layout-test-results from ews105 for mac-highsierra-wk2
none
Archive of layout-test-results from ews113 for mac-highsierra
none
WIP Patch
none
Archive of layout-test-results from ews102 for mac-highsierra
none
Patch none

Description Chris Dumez 2019-04-02 10:12:22 PDT
Align event dispatching logic with Blink and Gecko.
Comment 1 Chris Dumez 2019-04-02 10:13:18 PDT
Created attachment 366499 [details]
WIP Patch
Comment 2 EWS Watchlist 2019-04-02 11:07:13 PDT
Comment on attachment 366499 [details]
WIP Patch

Attachment 366499 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11740522

Number of test failures exceeded the failure limit.
Comment 3 EWS Watchlist 2019-04-02 11:07:14 PDT
Created attachment 366503 [details]
Archive of layout-test-results from ews102 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 4 EWS Watchlist 2019-04-02 11:15:51 PDT
Comment on attachment 366499 [details]
WIP Patch

Attachment 366499 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11740528

Number of test failures exceeded the failure limit.
Comment 5 EWS Watchlist 2019-04-02 11:15:52 PDT
Created attachment 366505 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 6 EWS Watchlist 2019-04-02 11:23:52 PDT
Comment on attachment 366499 [details]
WIP Patch

Attachment 366499 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11740519

Number of test failures exceeded the failure limit.
Comment 7 EWS Watchlist 2019-04-02 11:23:53 PDT
Created attachment 366508 [details]
Archive of layout-test-results from ews113 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 8 Chris Dumez 2019-04-02 12:15:40 PDT
Created attachment 366520 [details]
WIP Patch
Comment 9 EWS Watchlist 2019-04-02 13:21:28 PDT
Comment on attachment 366520 [details]
WIP Patch

Attachment 366520 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11742323

New failing tests:
fast/shadow-dom/capturing-and-bubbling-event-listeners-across-shadow-trees.html
media/media-load-event.html
Comment 10 EWS Watchlist 2019-04-02 13:21:29 PDT
Created attachment 366528 [details]
Archive of layout-test-results from ews102 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 11 Chris Dumez 2019-04-02 13:23:59 PDT
Created attachment 366529 [details]
Patch
Comment 12 Ryosuke Niwa 2019-04-02 14:12:03 PDT
Comment on attachment 366529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366529&action=review

> Source/WebCore/ChangeLog:14
> +        would first call the capturing ones and then the non-capturing ones. However,
> +        this behavior was not compatible with Gecko or Blink.

This is the new intended behavior after https://github.com/whatwg/dom/issues/685
We should just fix WPT tests instead.
Comment 13 Ryosuke Niwa 2019-04-02 14:13:45 PDT
The current WebKit behavior is intentional.