Summary: | Web Inspector: fake value descriptors for promises add a catch handler, preventing "rejectionhandled" events from being fired | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | benjamin, calvaris, commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=205439 | ||||||||||||
Attachments: |
|
Description
Devin Rousso
2019-04-02 00:19:03 PDT
Created attachment 366474 [details]
Patch
For bots, to see if any tests fail.
Comment on attachment 366474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366474&action=review r- just because this needs a test and we should be able to add one. Otherwise this looks great. > Source/JavaScriptCore/runtime/ErrorInstance.h:69 > + bool isNativeGetterTypeError() { return m_nativeGetterTypeError; } Nit: `const` > Source/WebCore/Modules/streams/WritableStream.js:157 > + return @Promise.@reject(@makeGetterTypeError("WritableStream", "closed")); Awesome! > Source/WebCore/bindings/js/JSDOMPromiseDeferred.h:260 > +JSC::EncodedJSValue createRejectedPromiseWithTypeError(JSC::ExecState&, const String&, bool forNativeGetter); Nit: This boolean should really be an enum ForNativeGetter { Yes, No }. Right now at callsites it is not easily readable. Created attachment 367455 [details]
Patch
Created attachment 367457 [details]
Patch
Comment on attachment 367457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367457&action=review > LayoutTests/inspector/runtime/promise-native-getter.html:22 > + }, 5); I'd make this 50 instead of 5, but it shouldn't really matter as long as it is enough of a tick. Comment on attachment 367457 [details]
Patch
r=me
Created attachment 367461 [details]
Patch
Comment on attachment 367461 [details] Patch Clearing flags on attachment: 367461 Committed r244312: <https://trac.webkit.org/changeset/244312> All reviewed patches have been landed. Closing bug. |