Add SPI to give injected bundles access to displayed PDFDocuments

• Component: WebKit API
• Status: RESOLVED FIXED

[Remy Demarest]

Add SPI to give injected bundles access to displayed PDFDocuments

[Remy Demarest]

<rdar://problem/49339242>

[Remy Demarest]

Created attachment 366445 [details]
Patch

[EWS Watchlist]

Attachment 366445 [details] did not pass style-queue:


ERROR: Source/WebKit/WebProcess/InjectedBundle/API/c/mac/WKBundlePageMac.mm:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/WebProcess/InjectedBundle/API/c/mac/WKBundlePageMac.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 366445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366445&action=review

> Source/WebKit/WebProcess/InjectedBundle/API/c/mac/WKBundlePageMac.h:40
> +#ifdef __OBJC__

I feel like at this point you can just toss the whole file in #ifdef __OBJC__, no need to open and close it a few times

> Source/WebKit/WebProcess/InjectedBundle/API/c/mac/WKBundlePageMac.mm:36
> +#include <WebCore/Frame.h>

#import!

[Remy Demarest]

Created attachment 366448 [details]
Updated patch

[Tim Horton]

Comment on attachment 366448 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366448&action=review

> Source/WebKit/WebProcess/InjectedBundle/API/c/mac/WKBundlePageMac.mm:48
> +    return pluginView->pdfDocumentForPrinting().get();

Unlikely to come up, but shouldn't this be a .autorelease()?

[Remy Demarest]

Created attachment 366451 [details]
Updated patch using autorelease()

[WebKit Commit Bot]

Comment on attachment 366451 [details]
Updated patch using autorelease()

Clearing flags on attachment: 366451

Committed r243731: <https://trac.webkit.org/changeset/243731>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.