Bug 196450

Summary:

Web Inspector: Sources: clicking on a breakpoint changes the path components to not match the script's path

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	mattbaker: review+
Patch	none

Description Devin Rousso 2019-04-01 11:48:56 PDT

# STEPS TO REPRODUCE:
1. inspect <https://webkit.org>
2. enable "Group by Path"
3. find and select the "global.js" script
4. set a breakpoint in that file
5. click on the breakpoint
 => "https://webkit.org > wp-content > themes > webkit > scripts > global.js" becomes just "global.js"
 => clicking on "global.js" has it's siblings as "All Exceptions" and "Uncaught Exceptions"

Comment 1 Radar WebKit Bug Importer 2019-04-01 11:49:49 PDT

<rdar://problem/49488099>

Comment 2 Radar WebKit Bug Importer 2019-04-01 11:50:53 PDT

<rdar://problem/49488100>

Comment 3 Devin Rousso 2019-09-28 21:22:09 PDT

Created attachment 379801 [details]
Patch

Comment 4 Matt Baker 2019-10-01 12:01:29 PDT

Comment on attachment 379801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379801&action=review

r=me

> Source/WebInspectorUI/ChangeLog:11
> +        well so that the hiererchical path component shows the right breadcrumb trail.

sp: hiererchical -> hierarchical

Comment 5 Devin Rousso 2019-10-01 13:04:15 PDT

Created attachment 379937 [details]
Patch

Comment 6 WebKit Commit Bot 2019-10-01 13:41:40 PDT

Comment on attachment 379937 [details]
Patch

Clearing flags on attachment: 379937

Committed r250580: <https://trac.webkit.org/changeset/250580>

Comment 7 WebKit Commit Bot 2019-10-01 13:41:41 PDT

All reviewed patches have been landed.  Closing bug.