Bug 196443

Summary:

Update the status of ResizeObserver in features.json

Product:

WebKit

Reporter:

cathiechen <cathiechen>

Component:

WebCore Misc.

Assignee:

cathiechen <cathiechen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, fred.wang, joepeck, rbuis, rego, rwlbuis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

cathiechen

Reported 2019-04-01 07:57:40 PDT

Update the status of ResizeObserver in features.json

Attachments
Patch (1.60 KB, patch) 2019-04-01 08:07 PDT, cathiechen	no flags	Details Formatted Diff Diff
Patch (1.64 KB, patch) 2019-04-01 20:43 PDT, cathiechen	no flags	Details Formatted Diff Diff
Patch (1.63 KB, patch) 2019-04-02 03:20 PDT, cathiechen	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

cathiechen

Comment 1 2019-04-01 08:07:50 PDT

Created attachment 366395 [details] Patch

Manuel Rego Casasnovas

Comment 2 2019-04-01 12:49:29 PDT

Comment on attachment 366395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366395&action=review Some nitpicks. > Source/WebCore/features.json:1139 > + "status": "Partially Supported" Nit: Maybe I'd say "In Development" as it's still behind build and runtime flags. Alos you could add: "enabled-by-default": false > Source/WebCore/features.json:1141 > + "url": "https://wicg.github.io/ResizeObserver/", Nit: I believe this should be now https://drafts.csswg.org/resize-observer/ > Source/WebCore/features.json:1144 > + "description": "An API for observing changes to Elementâs size.", I see a weird character here between "Element" and "size".

cathiechen

Comment 3 2019-04-01 20:43:55 PDT

Created attachment 366468 [details] Patch

cathiechen

Comment 4 2019-04-01 20:44:18 PDT

Comment on attachment 366395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366395&action=review Done! Thanks:) >> Source/WebCore/features.json:1139 >> + "status": "Partially Supported" > > Nit: Maybe I'd say "In Development" as it's still behind build and runtime flags. > Alos you could add: "enabled-by-default": false Done >> Source/WebCore/features.json:1141 >> + "url": "https://wicg.github.io/ResizeObserver/", > > Nit: I believe this should be now https://drafts.csswg.org/resize-observer/ Done >> Source/WebCore/features.json:1144 >> + "description": "An API for observing changes to Elementâs size.", > > I see a weird character here between "Element" and "size". Done

Manuel Rego Casasnovas

Comment 5 2019-04-02 03:15:46 PDT

Comment on attachment 366468 [details] Patch Thanks for updating features.json! BTW, you could have uploaded the 2nd version of the patch with "Reviewed by Rob Buis" already filled in the ChangeLog (anyway it's not a big deal in this case).

cathiechen

Comment 6 2019-04-02 03:20:21 PDT

Created attachment 366480 [details] Patch

cathiechen

Comment 7 2019-04-02 03:21:25 PDT

(In reply to Manuel Rego Casasnovas from comment #5) > Comment on attachment 366468 [details] > Patch > > Thanks for updating features.json! > > BTW, you could have uploaded the 2nd version of the patch with "Reviewed by > Rob Buis" already filled in the ChangeLog (anyway it's not a big deal in > this case). Done! Thanks :)

WebKit Commit Bot

Comment 8 2019-04-02 03:59:07 PDT

Comment on attachment 366480 [details] Patch Clearing flags on attachment: 366480 Committed r243739: <https://trac.webkit.org/changeset/243739>

WebKit Commit Bot

Comment 9 2019-04-02 03:59:09 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2019-04-02 04:00:26 PDT

<rdar://problem/49515062>

Note You need to log in before you can comment on or make changes to this bug.