| Summary: | Update the status of ResizeObserver in features.json | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | cathiechen <cathiechen> | ||||||||
| Component: | WebCore Misc. | Assignee: | cathiechen <cathiechen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, fred.wang, joepeck, rbuis, rego, rwlbuis, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
cathiechen
2019-04-01 07:57:40 PDT
Created attachment 366395 [details]
Patch
Comment on attachment 366395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366395&action=review Some nitpicks. > Source/WebCore/features.json:1139 > + "status": "Partially Supported" Nit: Maybe I'd say "In Development" as it's still behind build and runtime flags. Alos you could add: "enabled-by-default": false > Source/WebCore/features.json:1141 > + "url": "https://wicg.github.io/ResizeObserver/", Nit: I believe this should be now https://drafts.csswg.org/resize-observer/ > Source/WebCore/features.json:1144 > + "description": "An API for observing changes to Elementâs size.", I see a weird character here between "Element" and "size". Created attachment 366468 [details]
Patch
Comment on attachment 366395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366395&action=review Done! Thanks:) >> Source/WebCore/features.json:1139 >> + "status": "Partially Supported" > > Nit: Maybe I'd say "In Development" as it's still behind build and runtime flags. > Alos you could add: "enabled-by-default": false Done >> Source/WebCore/features.json:1141 >> + "url": "https://wicg.github.io/ResizeObserver/", > > Nit: I believe this should be now https://drafts.csswg.org/resize-observer/ Done >> Source/WebCore/features.json:1144 >> + "description": "An API for observing changes to Elementâs size.", > > I see a weird character here between "Element" and "size". Done Comment on attachment 366468 [details]
Patch
Thanks for updating features.json!
BTW, you could have uploaded the 2nd version of the patch with "Reviewed by Rob Buis" already filled in the ChangeLog (anyway it's not a big deal in this case).
Created attachment 366480 [details]
Patch
(In reply to Manuel Rego Casasnovas from comment #5) > Comment on attachment 366468 [details] > Patch > > Thanks for updating features.json! > > BTW, you could have uploaded the 2nd version of the patch with "Reviewed by > Rob Buis" already filled in the ChangeLog (anyway it's not a big deal in > this case). Done! Thanks :) Comment on attachment 366480 [details] Patch Clearing flags on attachment: 366480 Committed r243739: <https://trac.webkit.org/changeset/243739> All reviewed patches have been landed. Closing bug. |