Bug 196419

Summary:

Web Inspector: JSC Sampling Profiler thread not getting subtracted in CPU Usage Timeline

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2019-03-29 19:58:57 PDT

JSC Sampling Profiler thread not getting subtracted in CPU Usage Timeline

Oops, we forgot to call the platformSaveStateBeforeStarting function in the patch that was put up for review and landed...

Comment 1 Radar WebKit Bug Importer 2019-03-29 19:59:18 PDT

<rdar://problem/49444023>

Comment 2 Joseph Pecoraro 2019-03-29 20:01:21 PDT

Created attachment 366346 [details]
[PATCH] Proposed Fix

Comment 3 Devin Rousso 2019-03-29 20:09:06 PDT

Comment on attachment 366346 [details]
[PATCH] Proposed Fix

r=mews, oops :P

Comment 4 WebKit Commit Bot 2019-03-30 09:38:22 PDT

Comment on attachment 366346 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 366346

Committed r243679: <https://trac.webkit.org/changeset/243679>

Comment 5 WebKit Commit Bot 2019-03-30 09:38:23 PDT

All reviewed patches have been landed.  Closing bug.