Bug 196378

Summary:

REGRESSION (r243250): Text interactions are no longer suppressed when editing in some websites

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

HTML Editing

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+
Patch for landing	none

Description Wenson Hsieh 2019-03-28 16:04:03 PDT

<rdar://problem/49231299>

Comment 1 Wenson Hsieh 2019-03-28 21:44:27 PDT

Created attachment 366245 [details]
Patch

Comment 2 Simon Fraser (smfr) 2019-03-29 11:57:03 PDT

Comment on attachment 366245 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366245&action=review

> LayoutTests/editing/selection/ios/hide-selection-in-textarea-with-transform.html:41
> +function focusTextarea(overflow) {

{ on next line.

> LayoutTests/editing/selection/ios/hide-selection-in-textarea-with-transform.html:46
> +async function tapButtonAndWaitForKeyboard(button, caretShouldBeVisible) {

ditto

Comment 3 Wenson Hsieh 2019-03-29 12:30:11 PDT

Created attachment 366295 [details]
Patch for landing

Comment 4 WebKit Commit Bot 2019-03-29 13:09:08 PDT

Comment on attachment 366295 [details]
Patch for landing

Clearing flags on attachment: 366295

Committed r243656: <https://trac.webkit.org/changeset/243656>