Bug 196360

Summary: [iPad] Should open popover when the spacebar is pressed
Product: WebKit Reporter: Daniel Bates <dbates>
Component: UI EventsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar, PlatformOnly
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 12   
Bug Depends on: 196272    
Bug Blocks: 190571    
Attachments:
Description Flags
Patch and layout test
none
Patch and layout test
none
Patch (Rebased copy of Dan's patch) none

Daniel Bates
Reported 2019-03-28 11:55:00 PDT
Make iOS match Mac behavior. Pressing the spacebar when a popup button is focused (e.g. <select>) should open the picker/popover.
Attachments
Patch and layout test (26.92 KB, patch)
2019-03-28 15:25 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch and layout test (26.95 KB, patch)
2019-03-28 15:59 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (Rebased copy of Dan's patch) (26.94 KB, patch)
2019-04-09 13:24 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-03-28 11:56:23 PDT
<rdar://problem/49389129>
Daniel Bates
Comment 2 2019-03-28 14:37:47 PDT
For now let's keep the iPhone behavior of blurring the element when the Done button is pressed and hence pressing spacebar does nothing (because there is no focused element).
Daniel Bates
Comment 3 2019-03-28 15:25:20 PDT
Created attachment 366215 [details] Patch and layout test Test depends on the patch for bug #196272.
Daniel Bates
Comment 4 2019-03-28 15:59:34 PDT
Created attachment 366218 [details] Patch and layout test
Brent Fulgham
Comment 5 2019-04-09 13:24:58 PDT
Created attachment 367068 [details] Patch (Rebased copy of Dan's patch)
Brent Fulgham
Comment 6 2019-04-09 13:28:40 PDT
I uploaded a rebased copy of Dan's patch.
Brent Fulgham
Comment 7 2019-04-09 13:32:50 PDT
Comment on attachment 367068 [details] Patch (Rebased copy of Dan's patch) r=me, assuming ews is happy.
WebKit Commit Bot
Comment 8 2019-04-09 14:45:09 PDT
Comment on attachment 367068 [details] Patch (Rebased copy of Dan's patch) Clearing flags on attachment: 367068 Committed r244096: <https://trac.webkit.org/changeset/244096>
WebKit Commit Bot
Comment 9 2019-04-09 14:45:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.