Bug 196360

Summary: [iPad] Should open popover when the spacebar is pressed
Product: WebKit Reporter: Daniel Bates <dbates>
Component: UI EventsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar, PlatformOnly
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 12   
Bug Depends on: 196272    
Bug Blocks: 190571    
Attachments:
Description Flags
Patch and layout test
none
Patch and layout test
none
Patch (Rebased copy of Dan's patch) none

Description Daniel Bates 2019-03-28 11:55:00 PDT 
Make iOS match Mac behavior. Pressing the spacebar when a popup button is focused (e.g. <select>) should open the picker/popover.
Comment 1 Radar WebKit Bug Importer 2019-03-28 11:56:23 PDT 
<rdar://problem/49389129>
Comment 2 Daniel Bates 2019-03-28 14:37:47 PDT 
For now let's keep the iPhone behavior of blurring the element when the Done button is pressed and hence pressing spacebar does nothing (because there is no focused element).
Comment 3 Daniel Bates 2019-03-28 15:25:20 PDT 
Created attachment 366215 [details]
Patch and layout test

Test depends on the patch for bug #196272.
Comment 4 Daniel Bates 2019-03-28 15:59:34 PDT 
Created attachment 366218 [details]
Patch and layout test
Comment 5 Brent Fulgham 2019-04-09 13:24:58 PDT 
Created attachment 367068 [details]
Patch (Rebased copy of Dan's patch)
Comment 6 Brent Fulgham 2019-04-09 13:28:40 PDT 
I uploaded a rebased copy of Dan's patch.
Comment 7 Brent Fulgham 2019-04-09 13:32:50 PDT 
Comment on attachment 367068 [details]
Patch (Rebased copy of Dan's patch)

r=me, assuming ews is happy.
Comment 8 WebKit Commit Bot 2019-04-09 14:45:09 PDT 
Comment on attachment 367068 [details]
Patch (Rebased copy of Dan's patch)

Clearing flags on attachment: 367068

Committed r244096: <https://trac.webkit.org/changeset/244096>
Comment 9 WebKit Commit Bot 2019-04-09 14:45:11 PDT 
All reviewed patches have been landed.  Closing bug.