Summary: | Opcode.h(159,27): warning: adding 'unsigned int' to a string does not append to the string [-Wstring-plus-int] | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||
Component: | JavaScriptCore | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Fujii Hironori
2019-03-28 02:13:02 PDT
Created attachment 366158 [details]
Patch
I have questions. * How to test this code? * Is there a port enabling OPCODE_STATS? Created attachment 366159 [details]
Patch
If define ENABLE_OPCODE_STATS 1, can't compile due to other issues.
> In file included from DerivedSources\JavaScriptCore\unified-sources\UnifiedSource-f0a787a9-8.cpp:6:
> ..\..\Source\JavaScriptCore\bytecode/Opcode.cpp(97,38): error: no template named 'pair'; did you mean 'std::pair'?
> std::pair<int, int> leftPair = *(pair<int, int>*) left;
> ^~~~
> std::pair
> C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\utility(93,9): note: 'std::pair' declared here
> struct pair
> ^
> In file included from DerivedSources\JavaScriptCore\unified-sources\UnifiedSource-f0a787a9-8.cpp:6:
> ..\..\Source\JavaScriptCore\bytecode/Opcode.cpp(99,39): error: no template named 'pair'; did you mean 'std::pair'?
> std::pair<int, int> rightPair = *(pair<int, int>*) right;
> ^~~~
> std::pair
> C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\utility(93,9): note: 'std::pair' declared here
> struct pair
> ^
> 2 errors generated.
Comment on attachment 366159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366159&action=review > Source/JavaScriptCore/bytecode/Opcode.cpp:63 > + return &padding[stringLength - width]; out-of-bound access occurs if the opcode name is longer than width. Created attachment 366162 [details]
Patch
(In reply to Fujii Hironori from comment #2) > I have questions. > * How to test this code? Define ENABLE_OPCODE_STATS and execute jsc.exe and type "quit()". > * Is there a port enabling OPCODE_STATS? No. Committed r243633: <https://trac.webkit.org/changeset/243633> |