Bug 196336

Summary: [macOS] Select element doesn't show popup if select element had lost focus while popup was previosuly shown
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: FormsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, simon.fraser, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug thorton: review+

Ryosuke Niwa
Reported 2019-03-27 19:56:11 PDT
In the following example, when the select element loses focus while the popup is shown, clicking on the select element again does not open the popup. <!DOCTYPE html> <html> <select> <option>foo</option> <option>bar</option> </select> <script> const select = document.querySelector("select"); select.addEventListener("focus", () => setTimeout(() => select.blur(), 0), { once: true }); </script> </html>
Attachments
Fixes the bug (18.60 KB, patch)
2019-03-27 20:52 PDT, Ryosuke Niwa 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-03-27 19:56:31 PDT
<rdar://problem/47290452>
Ryosuke Niwa
Comment 2 2019-03-27 20:52:13 PDT
Created attachment 366148 [details] Fixes the bug
Tim Horton
Comment 3 2019-03-27 22:11:39 PDT
Comment on attachment 366148 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=366148&action=review > Source/WebKit/ChangeLog:16 > + to dismiss the popup over from JS seems to be flaky. "popup" or "pop over" or "popover" but not "popup over" IMO
Ryosuke Niwa
Comment 4 2019-03-27 23:05:44 PDT
(In reply to Tim Horton from comment #3) > Comment on attachment 366148 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366148&action=review > > > Source/WebKit/ChangeLog:16 > > + to dismiss the popup over from JS seems to be flaky. > > "popup" or "pop over" or "popover" but not "popup over" IMO Oops, I forgot to remove this comment. We do have tests.
Ryosuke Niwa
Comment 5 2019-03-27 23:22:44 PDT
Committed r243601: <https://trac.webkit.org/changeset/243601>
Note You need to log in before you can comment on or make changes to this bug.