Bug 196291

Summary:

Add SPI to access the WKNavigation from the navigation action and response

Product:

WebKit

Reporter:

David Quesada <david_quesada>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

achristensen, beidson, cdumez, ggaren, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch v2	none

David Quesada

Reported 2019-03-27 00:00:39 PDT

There is WKNavigationAction._mainFrameNavigation to access the navigation from the action. There should be similar SPI that works for subframe navigation actions and for the WKNavigationResponse.

Attachments
Patch (22.99 KB, patch) 2019-03-27 00:09 PDT, David Quesada	no flags	Details Formatted Diff Diff
Patch v2 (23.21 KB, patch) 2019-03-27 09:47 PDT, David Quesada	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

David Quesada

Comment 1 2019-03-27 00:02:02 PDT

rdar://problem/49310648

David Quesada

Comment 2 2019-03-27 00:09:06 PDT

Created attachment 366059 [details] Patch

David Quesada

Comment 3 2019-03-27 09:47:10 PDT

Created attachment 366076 [details] Patch v2 Try to fix the GTK and WPE builds

Sam Weinig

Comment 4 2019-03-27 11:21:16 PDT

This seems odd to me. WKNavigation is supposed to represent, and is publicly document as such, the navigation of a "webpage", which maps to main-frame navigations. I'm not sure exposing, even as SPI, navigation objects for subframes makes all that much sense.

Chris Dumez

Comment 5 2019-04-09 12:30:07 PDT

Comment on attachment 366076 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=366076&action=review > Source/WebKit/ChangeLog:9 > + Given a WKNavigationAction or a WKNavigationResponse, it should be possible to determine Sam is right that WKNavigation is supposed to represent a page (aka main frame) navigation so exposing it for subframes seems odd.

Geoffrey Garen

Comment 6 2019-04-09 12:58:38 PDT

I think you could achieve your stated goal by giving WKNavigationAction a property indicating whether it has the download attribute, and giving WKNavigationResponse a pointer to WKNavigationAction. That would avoid introducing a WKNavigation object for things that are not main frame navigations.

David Quesada

Comment 7 2019-04-09 15:21:39 PDT

Comment on attachment 366076 [details] Patch v2 After talking about this a bit more, Alex and I came up with another solution.

Note You need to log in before you can comment on or make changes to this bug.