Bug 196290

Summary: [iOS WK2] Fixed elements in frames can be misplaced sometimes
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ews-watchlist, fred.wang, jamesr, koivisto, luiz, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 190500    
Attachments:
Description Flags
Patch
none
Patch fred.wang: review+

Description Simon Fraser (smfr) 2019-03-26 22:34:01 PDT
[iOS WK2] Fixed elements in frames can be misplaced sometimes
Comment 1 Simon Fraser (smfr) 2019-03-26 22:37:34 PDT
Created attachment 366053 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-03-26 22:40:05 PDT
<rdar://problem/49313998>
Comment 3 Simon Fraser (smfr) 2019-03-26 23:24:06 PDT
Created attachment 366055 [details]
Patch
Comment 4 Frédéric Wang (:fredw) 2019-03-27 01:56:37 PDT
Comment on attachment 366055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366055&action=review

> LayoutTests/scrollingcoordinator/ios/fixed-in-frame-layer-reconcile-layer-position.html:54
> +            }, 100);

What is that?
Comment 5 Antti Koivisto 2019-03-27 05:30:55 PDT
Comment on attachment 366055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366055&action=review

> LayoutTests/scrollingcoordinator/ios/fixed-in-frame-layer-reconcile-layer-position.html:53
> +                //document.getElementById('box').style.top = '20px';
> +                <!-- document.body.style.backgroundColor = 'silver'; -->

Please don't land commented out code.
Comment 6 Simon Fraser (smfr) 2019-03-27 08:33:51 PDT
https://trac.webkit.org/changeset/243539/webkit
Comment 7 Simon Fraser (smfr) 2019-03-27 08:34:56 PDT
> https://bugs.webkit.org/attachment.cgi?id=366055&action=review
> 
> > LayoutTests/scrollingcoordinator/ios/fixed-in-frame-layer-reconcile-layer-position.html:53
> > +                //document.getElementById('box').style.top = '20px';
> > +                <!-- document.body.style.backgroundColor = 'silver'; -->
> 
> Please don't land commented out code.

Not even with two kinds of comments? :)

Cleaned up before landing. I didn't need the JS in the iframe.