[ContentChangeObserver] Do not use the global _WKContentChange in WebKitLegacy

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

ssia

[Radar WebKit Bug Importer]

<rdar://problem/49364417>

[zalan]

Created attachment 366150 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 366150 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366150&action=review

> Source/WebCore/ChangeLog:3
> +        [ContentChangeObserver] Do not use the global _WKContentChange in WebKitLegacy

This seems like the wrong title.

> Source/WebCore/ChangeLog:9
> +        With this patch all the content observation decision making paths are asynchronous both in WebKit and WebkitLegacy.

Or is this wrong?
Or are you doing two things at once and not clearly saying so?

[zalan]

Created attachment 366151 [details]
Patch

[zalan]

Created attachment 366187 [details]
Patch

[zalan]

iOS builds require WebKitBuild/Release-iphoneos//DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp to be removed first (or nuke WebKitBuild alternatively)

[Ryosuke Niwa]

Can we land this change?

[zalan]

(In reply to Ryosuke Niwa from comment #7)
> Can we land this change?
Absolutely!

[zalan]

Created attachment 368112 [details]
Patch

[zalan]

Committed r244588: <https://trac.webkit.org/changeset/244588>

[Shawn Roberts]

After changes in https://trac.webkit.org/changeset/244588

We are seeing build failures on iOS Simulator Release. Other queues have not caught up so it may be affecting other OpenSource builders. Is also causing internal build failures.

https://build.webkit.org/builders/Apple%20iOS%2012%20Release%20%28Build%29/builds/5629

   
https://build.webkit.org/builders/Apple%20iOS%2012%20Release%20%28Build%29/builds/5629/steps/compile-webkit/logs/stdio

ld: warning: directory not found for option '-F/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.0.sdk/System/Library/PrivateFrameworks'
Undefined symbols for architecture arm64:
  "_WKObservedContentChange", referenced from:
     -exported_symbol[s_list] command line option
  "_WKSetObservedContentChange", referenced from:
     -exported_symbol[s_list] command line option
ld: symbol(s) not found for architecture arm64

[Brent Fulgham]

If you happen to run into a linker error like this (x86 or arm64):

Undefined symbols for architecture x86_64:
 "_WKObservedContentChange", referenced from:
    -exported_symbol[s_list] command line option
 "_WKSetObservedContentChange", referenced from:
    -exported_symbol[s_list] command line option
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

please delete [...]/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp (or alternatively trigger a clean build).

[Shawn Roberts]

(In reply to Brent Fulgham from comment #12)
> If you happen to run into a linker error like this (x86 or arm64):
> 
> Undefined symbols for architecture x86_64:
>  "_WKObservedContentChange", referenced from:
>     -exported_symbol[s_list] command line option
>  "_WKSetObservedContentChange", referenced from:
>     -exported_symbol[s_list] command line option
> ld: symbol(s) not found for architecture x86_64
> clang: error: linker command failed with exit code 1 (use -v to see
> invocation)
> 
> please delete [...]/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp
> (or alternatively trigger a clean build).

Just started clean builds on the affected queue's so we should be good soon!