| Summary: | API::Data::createWithoutCopying should do a null check before calling CFRelease | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||
| Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, alecflett, beidson, commit-queue, ddkilzer, ews-watchlist, jiewen_tan, jsbell, sihui_liu, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 196319 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Jiewen Tan
2019-03-26 15:31:18 PDT
Created attachment 366016 [details]
Patch
Comment on attachment 366016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366016&action=review > Source/WebCore/Modules/indexeddb/IDBRequest.cpp:342 > m_transaction->abortDueToFailedRequest(DOMException::create(AbortError, "IDBTransaction will abort due to uncaught exception in an event handler"_s)); This is where causing the null pointer dereference. Comment on attachment 366016 [details]
Patch
Per personal conversation with Brady, we agree to separate the IndexedDB fix from this bug. Will have a new patch soon.
A patch is uploaded in Bug 196319 for the indexed db fix. Since the test of the above patch depends on that other patch to not crash, I will upload a patch here after that one is landed. Created attachment 366205 [details]
Patch
Comment on attachment 366205 [details]
Patch
Thanks, Alex.
Comment on attachment 366205 [details] Patch Clearing flags on attachment: 366205 Committed r243631: <https://trac.webkit.org/changeset/243631> All reviewed patches have been landed. Closing bug. |