Bug 196273

Summary: Update BrowserBench for JetStream2
Product: WebKit Reporter: Jon Davis <jond>
Component: WebCore JavaScriptAssignee: Jon Davis <jond>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Jon Davis 2019-03-26 14:58:17 PDT
Update the browserbench.org landing page to remove ARES-6 and replace JetStream references with JetStream2.
Comment 1 Jon Davis 2019-03-26 15:01:37 PDT
Created attachment 366006 [details]
Patch
Comment 2 Saam Barati 2019-03-26 15:04:38 PDT
Comment on attachment 366006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366006&action=review

> Websites/browserbench.org/ChangeLog:3
> +        Replaced JetStream references with JetStream 2, and removed ARES-6.

This line should be the title of your bugzilla. This comment can go below the "Reviewed by ..."

> Websites/browserbench.org/index.html:46
> +    srcset="resources/JetStream2-Logo.png 1x, resources/JetStream2-Logo@2x.png 2x" alt="JetStream">

JetStream => JetStream 2

> Websites/browserbench.org/index.html:47
> +<p>JetStream is a JavaScript benchmark suite focused on the most advanced web applications.</p>

JetStream 2
Comment 3 Jon Davis 2019-03-26 15:05:30 PDT
Created attachment 366008 [details]
Patch
Comment 4 Jon Davis 2019-03-26 15:07:02 PDT
Created attachment 366009 [details]
Patch
Comment 5 Saam Barati 2019-03-26 15:09:17 PDT
Comment on attachment 366009 [details]
Patch

r=me
Comment 6 Saam Barati 2019-03-26 15:20:04 PDT
Comment on attachment 366009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366009&action=review

> Websites/browserbench.org/index.html:44
> +<a class="benchmark" href="JetStream2.0" tabindex="0">

Sorry I missed this

href should remain to JetStream
Comment 7 Jon Davis 2019-03-26 15:22:09 PDT
Created attachment 366014 [details]
Patch
Comment 8 WebKit Commit Bot 2019-03-26 16:50:39 PDT
Comment on attachment 366014 [details]
Patch

Clearing flags on attachment: 366014

Committed r243526: <https://trac.webkit.org/changeset/243526>
Comment 9 WebKit Commit Bot 2019-03-26 16:50:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-03-26 17:13:31 PDT
<rdar://problem/49301914>