Bug 196268

Summary: Inhibit CFNetwork logging in private sessions
Product: WebKit Reporter: Keith Rollin <krollin>
Component: New BugsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keith Rollin
Reported 2019-03-26 13:27:16 PDT
Before performing any logging, the NetworkProcess checks to see if it's performing an operation associated with a private (ephemeral) browsing session. If so, it skips all logging. However, networking layers below the NetworkProcess don't know about private browsing, so they would still perform their own logging. CFNetwork now has a flag that lets us control that, so set it to False if private browsing.
Attachments
Patch (3.71 KB, patch)
2019-03-26 13:29 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Patch (1.68 KB, patch)
2019-04-01 16:44 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Rollin
Comment 1 2019-03-26 13:27:25 PDT
<rdar://problem/48210793>
Keith Rollin
Comment 2 2019-03-26 13:29:31 PDT
Created attachment 365993 [details] Patch
WebKit Commit Bot
Comment 3 2019-03-26 16:29:18 PDT
Comment on attachment 365993 [details] Patch Clearing flags on attachment: 365993 Committed r243524: <https://trac.webkit.org/changeset/243524>
WebKit Commit Bot
Comment 4 2019-03-26 16:29:20 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2019-03-26 18:12:52 PDT
Comment on attachment 365993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365993&action=review > Source/WTF/wtf/Platform.h:1529 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 60000) || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 130000) It should be PLATFORM(IOS) in the second clause, not IOS_FAMILY.
Keith Rollin
Comment 6 2019-03-26 22:51:09 PDT
Ugh. OK. So when should IOS vs. IOS_FAMILY be used? I was modeling my conditional on the one a few lines above: #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) #define HAVE_SANDBOX_ISSUE_MACH_EXTENSION_TO_PROCESS_BY_PID 1 #endif
Keith Rollin
Comment 7 2019-04-01 16:40:57 PDT
Re-opened to address Alexey's comment.
Keith Rollin
Comment 8 2019-04-01 16:44:42 PDT
Created attachment 366442 [details] Patch
WebKit Commit Bot
Comment 9 2019-04-02 10:46:13 PDT
Comment on attachment 366442 [details] Patch Clearing flags on attachment: 366442 Committed r243747: <https://trac.webkit.org/changeset/243747>
WebKit Commit Bot
Comment 10 2019-04-02 10:46:14 PDT
All reviewed patches have been landed. Closing bug.
Saam Barati
Comment 11 2019-04-03 17:52:25 PDT
(In reply to Keith Rollin from comment #0) > Before performing any logging, the NetworkProcess checks to see if it's > performing an operation associated with a private (ephemeral) browsing > session. If so, it skips all logging. However, networking layers below the > NetworkProcess don't know about private browsing, so they would still > perform their own logging. CFNetwork now has a flag that lets us control > that, so set it to False if private browsing. Why just in private browsing? I think we should always turn this logging off.
Keith Rollin
Comment 12 2019-04-03 21:16:54 PDT
That logging is priceless in tracking down networking issues. Why do you think it should be removed unconditionally?
Note You need to log in before you can comment on or make changes to this bug.