| Summary: | [ews-build] Get master_hostname dynamically in master.cfg | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, dewei_zhu, jbedard, lforschler, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2019-03-26 08:36:41 PDT
Created attachment 365967 [details]
Patch
Comment on attachment 365967 [details]
Patch
I think we should use pythons optimized code here instead of calling out to shell.
import socket
socket.gethostname()
or
socket.getfqdn()
I don't feel too strongly about it, so I'll r+ this, but in general I would guess it's more efficient.
Committed r243508: <https://trac.webkit.org/changeset/243508> > I think we should use pythons optimized code here instead of calling out to shell.
> import socket
> socket.gethostname()
Agree. Used this.
|