Bug 196255

Summary: [ews-build] Get master_hostname dynamically in master.cfg
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, dewei_zhu, jbedard, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch lforschler: review+

Aakash Jain
Reported 2019-03-26 08:36:41 PDT
[ews-build] We should get the master_hostname dynamically in master.cfg instead of hard-coding production server hostname.
Attachments
Patch (1.42 KB, patch)
2019-03-26 08:37 PDT, Aakash Jain 		lforschler: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-03-26 08:37:56 PDT
Created attachment 365967 [details] Patch
Lucas Forschler
Comment 2 2019-03-26 09:34:07 PDT
Comment on attachment 365967 [details] Patch I think we should use pythons optimized code here instead of calling out to shell. import socket socket.gethostname() or socket.getfqdn() I don't feel too strongly about it, so I'll r+ this, but in general I would guess it's more efficient.
Aakash Jain
Comment 3 2019-03-26 11:13:40 PDT
Committed r243508: <https://trac.webkit.org/changeset/243508>
Aakash Jain
Comment 4 2019-03-26 11:14:10 PDT
> I think we should use pythons optimized code here instead of calling out to shell. > import socket > socket.gethostname() Agree. Used this.
Radar WebKit Bug Importer
Comment 5 2019-03-26 11:14:18 PDT
<rdar://problem/49281738>
Note You need to log in before you can comment on or make changes to this bug.