Summary: | Primary cluster of measurement set should always contain latest point. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | dewei_zhu | ||||
Component: | New Bugs | Assignee: | dewei_zhu | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dewei_zhu, rniwa | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
dewei_zhu
2019-03-25 23:07:33 PDT
Created attachment 365948 [details]
Patch
Comment on attachment 365948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365948&action=review > Websites/perf.webkit.org/server-tests/api-measurement-set-tests.js:468 > + const currentRows = response['configurations']['current']; Can we also check that these times are earlier than the cluster start time, etc...? That is to make sure that the last data point was actually not within the time range of the primary cluster. This is to prevent the test case from being broken in the future when someone refractors it modifies the test for something else. Tracked in <rdar://problem/49285265>. Landed in r243510. |