Bug 196243

Summary:

Primary cluster of measurement set should always contain latest point.

Product:

WebKit

Reporter:

dewei_zhu

Component:

New Bugs

Assignee:

dewei_zhu

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dewei_zhu, rniwa

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review+

Description dewei_zhu 2019-03-25 23:07:33 PDT

Primary cluster of measurement set should always contain latest point.

Comment 1 dewei_zhu 2019-03-25 23:09:49 PDT

Created attachment 365948 [details]
Patch

Comment 2 Ryosuke Niwa 2019-03-26 11:33:27 PDT

Comment on attachment 365948 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365948&action=review

> Websites/perf.webkit.org/server-tests/api-measurement-set-tests.js:468
> +        const currentRows = response['configurations']['current'];

Can we also check that these times are earlier than the cluster start time, etc...?

Comment 3 Ryosuke Niwa 2019-03-26 11:35:09 PDT

That is to make sure that the last data point was actually not within the time range of the primary cluster. This is to prevent the test case from being broken in the future when someone refractors it modifies the test for something else.

Comment 4 dewei_zhu 2019-03-26 12:19:42 PDT

Tracked in <rdar://problem/49285265>. Landed in r243510.