| Summary: | Address NSWindow sometimes using WebKitTestRunnerEvent too early | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||||
| Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, lforschler, rniwa, thorton | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alexey Proskuryakov
2019-03-25 12:56:18 PDT
Created attachment 365886 [details]
proposed fix
Created attachment 365895 [details]
proposed fix
Comment on attachment 365895 [details] proposed fix Attachment 365895 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11664402 New failing tests: fast/images/animated-gif-window-resizing.html fast/animation/request-animation-frame-in-two-pages.html tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fast/dom/Geolocation/window-close-crash.html fast/events/page-visibility-iframe-move-test.html imported/w3c/web-platform-tests/intersection-observer/target-in-different-window.html Created attachment 365908 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 365933 [details]
proposed fix
Comment on attachment 365933 [details] proposed fix Rejecting attachment 365933 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 365933, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=365933&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=196211&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 365933 from bug 196211. Fetching: https://bugs.webkit.org/attachment.cgi?id=365933 Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Updating OpenSource Current branch master is up to date. Full output: https://webkit-queues.webkit.org/results/11669232 Indeed. Committed http://trac.webkit.org/r243496 |