Layout Test js/math-clz32.html is failing

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Per Arne Vollan]

The following layout test is failing on Windows:

js/math-clz32.html

Probable cause:

Unknown.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fmath-clz32.html

[Per Arne Vollan]

Created attachment 365894 [details]
Patch

[EWS Watchlist]

Comment on attachment 365894 [details]
Patch

Attachment 365894 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11670764

New failing tests:
animations/resume-after-page-cache.html

[EWS Watchlist]

Created attachment 365958 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Per Arne Vollan]

Created attachment 365979 [details]
Patch

[EWS Watchlist]

Comment on attachment 365979 [details]
Patch

Attachment 365979 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11675653

New failing tests:
js/math-clz32.html

[EWS Watchlist]

Created attachment 366011 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Per Arne Vollan]

Created attachment 366041 [details]
Patch

[Ross Kirsling]

Comment on attachment 366041 [details]
Patch

We should move the `bitSize64` declaration under #if COMPILER(GCC_COMPATIBLE) while we're at it.

[Ross Kirsling]

Er whoops, looks like the `- 1` from your first patch attempt is also necessary for x64.

(The off-by-one was pretty clearly introduced here: https://github.com/WebKit/webkit/commit/743154c6e5aef8c3d74d16540708f0c5ef09f5df#diff-9b03cfd7f9672cf12ab87ca5592ebd4cL670)

[Per Arne Vollan]

Created attachment 366068 [details]
Patch

[Per Arne Vollan]

(In reply to Ross Kirsling from comment #9)
> Er whoops, looks like the `- 1` from your first patch attempt is also
> necessary for x64.
> 
> (The off-by-one was pretty clearly introduced here:
> https://github.com/WebKit/webkit/commit/
> 743154c6e5aef8c3d74d16540708f0c5ef09f5df#diff-
> 9b03cfd7f9672cf12ab87ca5592ebd4cL670)

Thanks for reviewing! I have updated the patch.

[WebKit Commit Bot]

Comment on attachment 366068 [details]
Patch

Clearing flags on attachment: 366068

Committed r243544: <https://trac.webkit.org/changeset/243544>

[Radar WebKit Bug Importer]

<rdar://problem/60739695>