| Summary: | Skip WebAssembly test on 32-bit systems | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dominik Inführ <dominik.infuehr> | ||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, keith_miller, mark.lam, saam, webkit-bug-importer, ysuzuki | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Dominik Inführ
2019-03-25 09:58:45 PDT
Created attachment 365871 [details]
Patch
Invoking runDefault runs the test immediately, therefore make runDefault conditional. Comment on attachment 365871 [details]
Patch
I don’t think this is right. It’s definitely possible to have FTL and not warm. Additionally, it’s possible to have warm and not FTL. I would just remove the whole pragma.
Created attachment 365876 [details]
Patch
Tha(In reply to Keith Miller from comment #3) > Comment on attachment 365871 [details] > Patch > > I don’t think this is right. It’s definitely possible to have FTL and not > warm. Additionally, it’s possible to have warm and not FTL. I would just > remove the whole pragma. Thanks for the review! I've updated the patch to remove runDefault. (In reply to Keith Miller from comment #3) > Comment on attachment 365871 [details] > Patch > > I don’t think this is right. It’s definitely possible to have FTL and not > warm. Additionally, it’s possible to have warm and not FTL. I would just > remove the whole pragma. ugh autocorrect... that should be wasm. Created attachment 365968 [details]
Patch
Created attachment 366019 [details]
Patch
Comment on attachment 366019 [details] Patch Clearing flags on attachment: 366019 Committed r243529: <https://trac.webkit.org/changeset/243529> All reviewed patches have been landed. Closing bug. |