Bug 196206

Summary: Skip WebAssembly test on 32-bit systems
Product: WebKit Reporter: Dominik Inführ <dominik.infuehr>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Dominik Inführ
Reported 2019-03-25 09:58:45 PDT
Skip WebAssembly test on 32-bit systems
Attachments
Patch (1.07 KB, patch)
2019-03-25 09:59 PDT, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (1.21 KB, patch)
2019-03-25 11:06 PDT, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (1.26 KB, patch)
2019-03-26 09:12 PDT, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (1.22 KB, patch)
2019-03-26 16:18 PDT, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dominik Inführ
Comment 1 2019-03-25 09:59:01 PDT
Created attachment 365871 [details] Patch
Dominik Inführ
Comment 2 2019-03-25 10:02:51 PDT
Invoking runDefault runs the test immediately, therefore make runDefault conditional.
Keith Miller
Comment 3 2019-03-25 10:12:05 PDT
Comment on attachment 365871 [details] Patch I don’t think this is right. It’s definitely possible to have FTL and not warm. Additionally, it’s possible to have warm and not FTL. I would just remove the whole pragma.
Dominik Inführ
Comment 4 2019-03-25 11:06:51 PDT
Created attachment 365876 [details] Patch
Dominik Inführ
Comment 5 2019-03-25 11:07:58 PDT
Tha(In reply to Keith Miller from comment #3) > Comment on attachment 365871 [details] > Patch > > I don’t think this is right. It’s definitely possible to have FTL and not > warm. Additionally, it’s possible to have warm and not FTL. I would just > remove the whole pragma. Thanks for the review! I've updated the patch to remove runDefault.
Keith Miller
Comment 6 2019-03-25 11:08:50 PDT
(In reply to Keith Miller from comment #3) > Comment on attachment 365871 [details] > Patch > > I don’t think this is right. It’s definitely possible to have FTL and not > warm. Additionally, it’s possible to have warm and not FTL. I would just > remove the whole pragma. ugh autocorrect... that should be wasm.
Dominik Inführ
Comment 7 2019-03-26 09:12:47 PDT
Created attachment 365968 [details] Patch
Dominik Inführ
Comment 8 2019-03-26 16:18:26 PDT
Created attachment 366019 [details] Patch
WebKit Commit Bot
Comment 9 2019-03-26 17:03:01 PDT
Comment on attachment 366019 [details] Patch Clearing flags on attachment: 366019 Committed r243529: <https://trac.webkit.org/changeset/243529>
WebKit Commit Bot
Comment 10 2019-03-26 17:03:02 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-03-26 17:05:05 PDT
<rdar://problem/49301482>
Note You need to log in before you can comment on or make changes to this bug.