Bug 196206

Summary: Skip WebAssembly test on 32-bit systems
Product: WebKit Reporter: Dominik Inführ <dominik.infuehr>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, sbarati, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Dominik Inführ 2019-03-25 09:58:45 PDT
Skip WebAssembly test on 32-bit systems
Comment 1 Dominik Inführ 2019-03-25 09:59:01 PDT
Created attachment 365871 [details]
Patch
Comment 2 Dominik Inführ 2019-03-25 10:02:51 PDT
Invoking runDefault runs the test immediately, therefore make runDefault conditional.
Comment 3 Keith Miller 2019-03-25 10:12:05 PDT
Comment on attachment 365871 [details]
Patch

I don’t think this is right. It’s definitely possible to have FTL and not warm. Additionally, it’s possible to have warm and not FTL. I would just remove the whole pragma.
Comment 4 Dominik Inführ 2019-03-25 11:06:51 PDT
Created attachment 365876 [details]
Patch
Comment 5 Dominik Inführ 2019-03-25 11:07:58 PDT
Tha(In reply to Keith Miller from comment #3)
> Comment on attachment 365871 [details]
> Patch
> 
> I don’t think this is right. It’s definitely possible to have FTL and not
> warm. Additionally, it’s possible to have warm and not FTL. I would just
> remove the whole pragma.

Thanks for the review! I've updated the patch to remove runDefault.
Comment 6 Keith Miller 2019-03-25 11:08:50 PDT
(In reply to Keith Miller from comment #3)
> Comment on attachment 365871 [details]
> Patch
> 
> I don’t think this is right. It’s definitely possible to have FTL and not
> warm. Additionally, it’s possible to have warm and not FTL. I would just
> remove the whole pragma.

ugh autocorrect... that should be wasm.
Comment 7 Dominik Inführ 2019-03-26 09:12:47 PDT
Created attachment 365968 [details]
Patch
Comment 8 Dominik Inführ 2019-03-26 16:18:26 PDT
Created attachment 366019 [details]
Patch
Comment 9 WebKit Commit Bot 2019-03-26 17:03:01 PDT
Comment on attachment 366019 [details]
Patch

Clearing flags on attachment: 366019

Committed r243529: <https://trac.webkit.org/changeset/243529>
Comment 10 WebKit Commit Bot 2019-03-26 17:03:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2019-03-26 17:05:05 PDT
<rdar://problem/49301482>