Bug 196193

Summary: Pull IPadUserInterfaceSwizzler out into a separate header file
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: New BugsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, thorton, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Wenson Hsieh
Reported 2019-03-24 22:39:36 PDT
Pull IPadUserInterfaceSwizzler out into a separate header file
Attachments
Patch (6.60 KB, patch)
2019-03-24 22:40 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (6.63 KB, patch)
2019-03-25 08:16 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-03-24 22:40:56 PDT
Created attachment 365850 [details] Patch
Anders Carlsson
Comment 2 2019-03-25 08:08:09 PDT
Comment on attachment 365850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365850&action=review > Tools/TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h:41 > + static UIUserInterfaceIdiom padUserInterfaceIdiom() Shouldn't this at least take self and _cmd parameters?
Wenson Hsieh
Comment 3 2019-03-25 08:16:57 PDT
Created attachment 365864 [details] Patch
Wenson Hsieh
Comment 4 2019-03-25 08:17:08 PDT
(In reply to Anders Carlsson from comment #2) > Comment on attachment 365850 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=365850&action=review > > > Tools/TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h:41 > > + static UIUserInterfaceIdiom padUserInterfaceIdiom() > > Shouldn't this at least take self and _cmd parameters? It probably should!
Wenson Hsieh
Comment 5 2019-03-25 11:43:08 PDT
Comment on attachment 365864 [details] Patch Thanks for the review!
WebKit Commit Bot
Comment 6 2019-03-25 12:09:23 PDT
Comment on attachment 365864 [details] Patch Clearing flags on attachment: 365864 Committed r243445: <https://trac.webkit.org/changeset/243445>
WebKit Commit Bot
Comment 7 2019-03-25 12:09:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.