Bug 196193

Summary: Pull IPadUserInterfaceSwizzler out into a separate header file
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: New BugsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, thorton, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Wenson Hsieh 2019-03-24 22:39:36 PDT
Pull IPadUserInterfaceSwizzler out into a separate header file
Comment 1 Wenson Hsieh 2019-03-24 22:40:56 PDT
Created attachment 365850 [details]
Patch
Comment 2 Anders Carlsson 2019-03-25 08:08:09 PDT
Comment on attachment 365850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365850&action=review

> Tools/TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h:41
> +    static UIUserInterfaceIdiom padUserInterfaceIdiom()

Shouldn't this at least take self and _cmd parameters?
Comment 3 Wenson Hsieh 2019-03-25 08:16:57 PDT
Created attachment 365864 [details]
Patch
Comment 4 Wenson Hsieh 2019-03-25 08:17:08 PDT
(In reply to Anders Carlsson from comment #2)
> Comment on attachment 365850 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=365850&action=review
> 
> > Tools/TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h:41
> > +    static UIUserInterfaceIdiom padUserInterfaceIdiom()
> 
> Shouldn't this at least take self and _cmd parameters?

It probably should!
Comment 5 Wenson Hsieh 2019-03-25 11:43:08 PDT
Comment on attachment 365864 [details]
Patch

Thanks for the review!
Comment 6 WebKit Commit Bot 2019-03-25 12:09:23 PDT
Comment on attachment 365864 [details]
Patch

Clearing flags on attachment: 365864

Committed r243445: <https://trac.webkit.org/changeset/243445>
Comment 7 WebKit Commit Bot 2019-03-25 12:09:25 PDT
All reviewed patches have been landed.  Closing bug.