Summary: | Reflect HTMLLinkElement.as according to the spec | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||||||||
Component: | Page Loading | Assignee: | Rob Buis <rbuis> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | beidson, cdumez, commit-queue, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, webkit-bug-importer, youennf | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | Other | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
Description
Rob Buis
2019-03-24 09:13:04 PDT
Created attachment 365831 [details]
Patch
Created attachment 365834 [details]
Patch
Comment on attachment 365834 [details] Patch Attachment 365834 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11646301 New failing tests: imported/w3c/web-platform-tests/html/dom/reflection-metadata.html Created attachment 365835 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 365836 [details]
Patch
This patch also changes WebCore behavior, can you reflect that in the title please (both bug and patch). Created attachment 365838 [details]
Patch
Comment on attachment 365838 [details] Patch Clearing flags on attachment: 365838 Committed r243435: <https://trac.webkit.org/changeset/243435> All reviewed patches have been landed. Closing bug. Comment on attachment 365838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365838&action=review > Source/WebCore/html/HTMLLinkElement.cpp:248 > + return as.convertToASCIILowercase(); In other similar call sites, we return ASCIILiteral constants rather than calling convertToASCIILowercase. Ideally I’d like to see a consistent idiom for our implementations of enumerated attributes. To get realty fancy, maybe we could even have the IDL generate appropriate reflection getters/setters for them without hand-writing the C++ code. |