| Summary: | [Apple Pay] Call +canMakePayments on a work queue | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, andersca, beidson, cdumez, commit-queue, ews-watchlist, koivisto, thorton, timothy, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Andy Estes
2019-03-23 14:43:16 PDT
Created attachment 365817 [details]
Patch
Attachment 365817 [details] did not pass style-queue:
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.cpp:48: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 365818 [details]
Patch
Attachment 365818 [details] did not pass style-queue:
ERROR: Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.cpp:48: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 365818 [details] Patch Rejecting attachment 365818 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 365818, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=365818&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=196179&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 365818 from bug 196179. Fetching: https://bugs.webkit.org/attachment.cgi?id=365818 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brady Eidson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 5 diffs from patch file(s). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.cpp Hunk #2 succeeded at 71 (offset -5 lines). patching file Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h Hunk #2 FAILED at 135. Hunk #3 succeeded at 184 (offset -2 lines). 1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h.rej patching file Source/WebKit/Shared/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm patching file Source/WebKit/Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brady Eidson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/11662548 Created attachment 365883 [details]
Patch
Comment on attachment 365883 [details] Patch Clearing flags on attachment: 365883 Committed r243447: <https://trac.webkit.org/changeset/243447> All reviewed patches have been landed. Closing bug. |