Summary: | XMLHttpRequestUpload's loadstart event not correctly initialized | ||
---|---|---|---|
Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
Component: | DOM | Assignee: | Chris Dumez <cdumez> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | achristensen, beidson, cdumez, commit-queue, ews-watchlist, ggaren, rniwa, rwlbuis, webkit-bug-importer, youennf |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Attachments: |
Description
Anne van Kesteren
2019-03-23 02:02:10 PDT
Created attachment 366013 [details]
Patch
Comment on attachment 366013 [details] Patch Attachment 366013 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11676610 New failing tests: imported/w3c/web-platform-tests/xhr/event-error-order.sub.html Created attachment 366018 [details]
Archive of layout-test-results from ews103 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
--- /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/imported/w3c/web-platform-tests/xhr/event-error-order.sub-expected.txt +++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/imported/w3c/web-platform-tests/xhr/event-error-order.sub-actual.txt @@ -1,3 +1,3 @@ -FAIL XMLHttpRequest: event - error (order of events) assert_equals: expected "upload.loadstart(0,12,true)" but got "upload.loadstart(0,0,false)" +PASS XMLHttpRequest: event - error (order of events) I guess Mac-wk1 has a platform-specific expectation file. Created attachment 366021 [details]
Patch
Comment on attachment 366021 [details] Patch Attachment 366021 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11677153 New failing tests: imported/w3c/web-platform-tests/xhr/event-timeout-order.htm Created attachment 366026 [details]
Archive of layout-test-results from ews101 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 366021 [details] Patch Attachment 366021 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11677513 New failing tests: imported/w3c/web-platform-tests/xhr/event-timeout-order.htm Created attachment 366028 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 366021 [details] Patch Attachment 366021 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11677539 New failing tests: imported/w3c/web-platform-tests/xhr/event-timeout-order.htm Created attachment 366031 [details]
Archive of layout-test-results from ews113 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 366075 [details]
Patch
Comment on attachment 366075 [details] Patch Clearing flags on attachment: 366075 Committed r243551: <https://trac.webkit.org/changeset/243551> All reviewed patches have been landed. Closing bug. Reverted r243551 for reason: Seems to have broken file uploads to SoundCloud Committed r243756: <https://trac.webkit.org/changeset/243756> (In reply to Chris Dumez from comment #16) > Reverted r243551 for reason: > > Seems to have broken file uploads to SoundCloud > > Committed r243756: <https://trac.webkit.org/changeset/243756> Steps to reproduce: 1 - Login to soundcloud 2 - "Upload" 3 - Pick an audio file and upload it Results: The progress bar for the upload never shows any progress (Hadn't gotten around to checking the JS console, probably should have) Expected: The process bar shows progress right away. Notes: I found this and explored on device. Unclear if it affects desktop/sim the same Comment on attachment 366075 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366075&action=review > Source/WebCore/xml/XMLHttpRequest.cpp:949 > + if (m_response.isNull()) { This is the part that broke SoundCloud. SoundCloud does not seem to send us a response and get expects progress events, we therefore cannot delay sending the progress events until we have a response. Created attachment 366544 [details]
Patch
Comment on attachment 366544 [details] Patch Clearing flags on attachment: 366544 Committed r243765: <https://trac.webkit.org/changeset/243765> All reviewed patches have been landed. Closing bug. |