Summary: | [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||||
Component: | MathML | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | bugs-noreply, commit-queue, dbarton, ews-watchlist, mcatanzaro, rbuis, rniwa, rwlbuis | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 195797 | ||||||||||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2019-03-22 04:37:59 PDT
Created attachment 365712 [details]
Patch
Created attachment 365723 [details]
Patch
Comment on attachment 365723 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365723&action=review > Source/WebCore/mathml/MathMLFractionElement.cpp:58 > + if (!document().settings().deprecatedMathMLEnabled()) { This check isn't right. What we want is something like coreMathMLEnabled, which is disabled by default and enabled on GTK+/WPE. > Source/WebCore/page/Settings.yaml:824 > +deprecatedMathMLEnabled: > + initial: false We don't want to disable this feature in WebKitLegacy. In fact iBooks uses WebKitLegacy. In fact, we should keep the initial true and only disable non-core MathML in GTK+/WPE ports. > Source/WebKit/Shared/WebPreferences.yaml:1636 > + category: experimental This categorization isn't right. Having non-Core MathML feature is definitely not experimental. On the contrary, disabling those features is experimental. This problem goes away one we replace this with CoreMathMLEnabled instead. Created attachment 365824 [details]
Patch
Created attachment 365826 [details]
Patch
Comment on attachment 365826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365826&action=review Patch LGTM. > Source/WebCore/ChangeLog:9 > + adds a condition to disable thin", "thick", "medium" values of thin misses an opening '"'. > LayoutTests/imported/w3c/ChangeLog:9 > + adds a condition to disable thin", "thick", "medium" values of Ditto. Created attachment 366260 [details]
Patch
(In reply to Rob Buis from comment #6) > Comment on attachment 365826 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=365826&action=review > > Patch LGTM. > > > Source/WebCore/ChangeLog:9 > > + adds a condition to disable thin", "thick", "medium" values of > > thin misses an opening '"'. > > > LayoutTests/imported/w3c/ChangeLog:9 > > + adds a condition to disable thin", "thick", "medium" values of > > Ditto. Thanks. I fixed the change logs and also resolved merge conflicts after https://trac.webkit.org/changeset/243643/webkit ; hopefully this is still working. Comment on attachment 366260 [details]
Patch
This looks good to me, but I would like others to review the new runtime flag, given earlier discussion.
(In reply to Rob Buis from comment #9) > Comment on attachment 366260 [details] > Patch > > This looks good to me, but I would like others to review the new runtime > flag, given earlier discussion. @Ryosuke Are you happy with the latest version of the patch? Created attachment 368768 [details]
Patch
Comment on attachment 368768 [details] Patch Clearing flags on attachment: 368768 Committed r244869: <https://trac.webkit.org/changeset/244869> All reviewed patches have been landed. Closing bug. Please CC webkitgtk-bugs for GTK/WPE bugs. We need to maintain web compat with Safari, so if Safari will retain these features, that means we should as well, however ill-advised.... |