Bug 196117

Summary: Web Inspector: Use CSS variables for text color in Computed panel
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Image] Dark mode with patch applied
none
[Image] Before the patch none

Nikita Vasilyev
Reported 2019-03-21 16:19:15 PDT
ComputedStyleSection.css has hardcoded colors `hsl(0, 0%, 50%)` and `hsl(0, 0%, 50%)`, which in the light mode match exactly --text-color-tertiary and --text-color-secondary respectively.
Attachments
Patch (1.92 KB, patch)
2019-03-21 16:20 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Image] Dark mode with patch applied (76.58 KB, image/png)
2019-03-21 16:23 PDT, Nikita Vasilyev 		no flags
Details
[Image] Before the patch (82.04 KB, image/png)
2019-03-21 16:25 PDT, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2019-03-21 16:20:02 PDT
Created attachment 365636 [details] Patch
Nikita Vasilyev
Comment 2 2019-03-21 16:23:56 PDT
Created attachment 365638 [details] [Image] Dark mode with patch applied
Nikita Vasilyev
Comment 3 2019-03-21 16:25:51 PDT
Created attachment 365640 [details] [Image] Before the patch
Joseph Pecoraro
Comment 4 2019-03-21 16:32:26 PDT
Light mode before/after? Since the --text-color-tertiary doesn't change between light/dark mode.
Nikita Vasilyev
Comment 5 2019-03-21 17:04:30 PDT
(In reply to Joseph Pecoraro from comment #4) > Light mode before/after? Since the --text-color-tertiary doesn't change > between light/dark mode. Light mode before and after are exactly the same because the hardcoded colors matched the variables!
WebKit Commit Bot
Comment 6 2019-03-21 18:22:53 PDT
Comment on attachment 365636 [details] Patch Clearing flags on attachment: 365636 Committed r243352: <https://trac.webkit.org/changeset/243352>
WebKit Commit Bot
Comment 7 2019-03-21 18:22:55 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-03-21 18:23:20 PDT
<rdar://problem/49134295>
Note You need to log in before you can comment on or make changes to this bug.