Bug 196117

Summary: Web Inspector: Use CSS variables for text color in Computed panel
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Description Flags
[Image] Dark mode with patch applied
[Image] Before the patch none

Description Nikita Vasilyev 2019-03-21 16:19:15 PDT
ComputedStyleSection.css has hardcoded colors `hsl(0, 0%, 50%)` and `hsl(0, 0%, 50%)`,
which in the light mode match exactly --text-color-tertiary and --text-color-secondary respectively.
Comment 1 Nikita Vasilyev 2019-03-21 16:20:02 PDT
Created attachment 365636 [details]
Comment 2 Nikita Vasilyev 2019-03-21 16:23:56 PDT
Created attachment 365638 [details]
[Image] Dark mode with patch applied
Comment 3 Nikita Vasilyev 2019-03-21 16:25:51 PDT
Created attachment 365640 [details]
[Image] Before the patch
Comment 4 Joseph Pecoraro 2019-03-21 16:32:26 PDT
Light mode before/after? Since the --text-color-tertiary doesn't change between light/dark mode.
Comment 5 Nikita Vasilyev 2019-03-21 17:04:30 PDT
(In reply to Joseph Pecoraro from comment #4)
> Light mode before/after? Since the --text-color-tertiary doesn't change
> between light/dark mode.

Light mode before and after are exactly the same because the hardcoded colors matched the variables!
Comment 6 WebKit Commit Bot 2019-03-21 18:22:53 PDT
Comment on attachment 365636 [details]

Clearing flags on attachment: 365636

Committed r243352: <https://trac.webkit.org/changeset/243352>
Comment 7 WebKit Commit Bot 2019-03-21 18:22:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-03-21 18:23:20 PDT