Summary: | Fix key path extraction code in IndexedDB to check own property | ||
---|---|---|---|
Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> |
Component: | New Bugs | Assignee: | Sihui Liu <sihui_liu> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | alecflett, beidson, commit-queue, ews-watchlist, jsbell, rniwa, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Attachments: |
Description
Sihui Liu
2019-03-21 11:55:17 PDT
Created attachment 365585 [details]
Patch
Comment on attachment 365585 [details] Patch Attachment 365585 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11603001 New failing tests: storage/indexeddb/structured-clone-private.html storage/indexeddb/structured-clone.html Created attachment 365601 [details]
Archive of layout-test-results from ews102 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 365585 [details] Patch Attachment 365585 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11603603 New failing tests: storage/indexeddb/structured-clone-private.html storage/indexeddb/structured-clone.html Created attachment 365617 [details]
Archive of layout-test-results from ews115 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 365585 [details] Patch Attachment 365585 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11604279 New failing tests: storage/indexeddb/structured-clone-private.html Created attachment 365620 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Created attachment 365621 [details]
Patch
Comment on attachment 365621 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365621&action=review > Source/WebCore/ChangeLog:3 > + Fix three IDB WPT tests Let's update the bug title as I renamed. This doesn't tell us what we're doing at all. You can mention that you're fixing a few other bugs as well. > Source/WebCore/bindings/js/IDBBindingUtilities.cpp:70 > + if (obj->inherits<JSArray>(vm) && (keyPathElement == "length")) { I think we need to use isArray in ArrayConstructor.h instead. No parenthesis is needed around keyPathElement ==. > Source/WebCore/bindings/js/IDBBindingUtilities.cpp:71 > + result = jsNumber(asArray(object)->length()); And then run [[GET]] here. > Source/WebCore/bindings/js/IDBBindingUtilities.cpp:75 > + result = obj->get(&exec, identifier); I don't think we should be running getter here. To something like jsBlob.wrapped()->size() > Source/WebCore/bindings/js/IDBBindingUtilities.cpp:79 > + result = obj->get(&exec, identifier); Ditto. Comment on attachment 365621 [details] Patch Attachment 365621 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11605387 New failing tests: imported/w3c/web-platform-tests/IndexedDB/wasm-module-value.html Created attachment 365634 [details]
Archive of layout-test-results from ews101 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 365637 [details]
Patch for landing
Comment on attachment 365637 [details] Patch for landing Clearing flags on attachment: 365637 Committed r243348: <https://trac.webkit.org/changeset/243348> All reviewed patches have been landed. Closing bug. Comment on attachment 365637 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=365637&action=review > Source/WebCore/bindings/js/IDBBindingUtilities.cpp:76 > + result = jsNumber(jsCast<JSBlob*>(obj)->wrapped().size()); I think it would have been better to have a local variable like this to share the code between two code paths: Blob& blob = jsCast<JSBlob*>(obj)->wrapped() > Source/WebCore/bindings/js/IDBBindingUtilities.cpp:85 > + if (keyPathElement == "name") { Ditto. |