Summary: | Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order. | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||||||||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, Hironori.Fujii, rniwa, webkit-bug-importer | ||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||
Bug Depends on: | 196095 | ||||||||||||||||||||||
Bug Blocks: | |||||||||||||||||||||||
Attachments: |
|
Description
Jer Noble
2019-03-21 11:21:05 PDT
Created attachment 365724 [details]
Patch
Comment on attachment 365724 [details] Patch Attachment 365724 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11613508 New failing tests: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html Created attachment 365729 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 365724 [details] Patch Attachment 365724 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11613630 New failing tests: media/track/track-in-band-metadata-display-order.html Created attachment 365734 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 365865 [details]
Patch
Comment on attachment 365865 [details] Patch Attachment 365865 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11660826 New failing tests: media/track/track-in-band-metadata-display-order.html Created attachment 365873 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 365878 [details]
Patch
Comment on attachment 365878 [details] Patch Clearing flags on attachment: 365878 Committed r243450: <https://trac.webkit.org/changeset/243450> All reviewed patches have been landed. Closing bug. AppleWin and WinCairo port builds get broken. https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Build%29/builds/3374/steps/compile-webkit/logs/stdio > WebCoreTestSupport.lib(JSInternals.obj) : error LNK2019: unresolved external symbol "protected: __thiscall WebCore::JSTextTrackCueGeneric::JSTextTrackCueGeneric(class JSC::Structure *,class WebCore::JSDOMGlobalObject &,class WTF::Ref<class WebCore::TextTrackCueGeneric,struct WTF::DumbPtrTraits<class WebCore::TextTrackCueGeneric> > &&)" (??0JSTextTrackCueGeneric@WebCore@@IAE@PAVStructure@JSC@@AAVJSDOMGlobalObject@1@$$QAV?$Ref@VTextTrackCueGeneric@WebCore@@U?$DumbPtrTraits@VTextTrackCueGeneric@WebCore@@@WTF@@@WTF@@@Z) referenced in function "public: static class WebCore::JSTextTrackCueGeneric * __cdecl WebCore::JSTextTrackCueGeneric::create(class JSC::Structure *,class WebCore::JSDOMGlobalObject *,class WTF::Ref<class WebCore::TextTrackCueGeneric,struct WTF::DumbPtrTraits<class WebCore::TextTrackCueGeneric> > &&)" (?create@JSTextTrackCueGeneric@WebCore@@SAPAV12@PAVStructure@JSC@@PAVJSDOMGlobalObject@2@$$QAV?$Ref@VTextTrackCueGeneric@WebCore@@U?$DumbPtrTraits@VTextTrackCueGeneric@WebCore@@@WTF@@@WTF@@@Z) [C:\cygwin\home\buildbot\worker\win7-release-i386\build\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj] > WebCoreTestSupport.lib(JSInternals.obj) : error LNK2019: unresolved external symbol "protected: void __thiscall WebCore::JSTextTrackCueGeneric::finishCreation(class JSC::VM &)" (?finishCreation@JSTextTrackCueGeneric@WebCore@@IAEXAAVVM@JSC@@@Z) referenced in function "public: static class WebCore::JSTextTrackCueGeneric * __cdecl WebCore::JSTextTrackCueGeneric::create(class JSC::Structure *,class WebCore::JSDOMGlobalObject *,class WTF::Ref<class WebCore::TextTrackCueGeneric,struct WTF::DumbPtrTraits<class WebCore::TextTrackCueGeneric> > &&)" (?create@JSTextTrackCueGeneric@WebCore@@SAPAV12@PAVStructure@JSC@@PAVJSDOMGlobalObject@2@$$QAV?$Ref@VTextTrackCueGeneric@WebCore@@U?$DumbPtrTraits@VTextTrackCueGeneric@WebCore@@@WTF@@@WTF@@@Z) [C:\cygwin\home\buildbot\worker\win7-release-i386\build\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj] > WebCoreTestSupport.lib(JSInternals.obj) : error LNK2019: unresolved external symbol "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::TextTrackCueGeneric &)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@AAVTextTrackCueGeneric@1@@Z) referenced in function "__int64 __cdecl WebCore::jsInternalsPrototypeFunctionCreateGenericCueBody(class JSC::ExecState *,class WebCore::JSInternals *,class JSC::ThrowScope &)" (?jsInternalsPrototypeFunctionCreateGenericCueBody@WebCore@@YA_JPAVExecState@JSC@@PAVJSInternals@1@AAVThrowScope@3@@Z) [C:\cygwin\home\buildbot\worker\win7-release-i386\build\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj] > WebCoreTestSupport.lib(JSInternals.obj) : error LNK2001: unresolved external symbol "protected: static struct JSC::ClassInfo const WebCore::JSTextTrackCueGeneric::s_info" (?s_info@JSTextTrackCueGeneric@WebCore@@1UClassInfo@JSC@@B) [C:\cygwin\home\buildbot\worker\win7-release-i386\build\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj] Hmm, weird. I don't know how to fix this. Seems we should revert this until someone find a solution. Created attachment 366502 [details]
Patch
Created attachment 366527 [details]
Patch
Comment on attachment 366527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366527&action=review > Source/WebCore/html/track/TextTrackCueGeneric.idl:31 > + ExportMacro=WEBCORE_TESTSUPPORT_EXPORT, Windows ports are still broken. If I replace this WEBCORE_TESTSUPPORT_EXPORT with WEBCORE_EXPORT, it can compile. I don't understand WEBCORE_TESTSUPPORT_EXPORT. What is the difference WEBCORE_TESTSUPPORT_EXPORT and WEBCORE_EXPORT? (In reply to Fujii Hironori from comment #17) > Comment on attachment 366527 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366527&action=review > > > Source/WebCore/html/track/TextTrackCueGeneric.idl:31 > > + ExportMacro=WEBCORE_TESTSUPPORT_EXPORT, > > Windows ports are still broken. > If I replace this WEBCORE_TESTSUPPORT_EXPORT with WEBCORE_EXPORT, it can > compile. > I don't understand WEBCORE_TESTSUPPORT_EXPORT. What is the difference > WEBCORE_TESTSUPPORT_EXPORT and WEBCORE_EXPORT? The intent of WEBCORE_TESTSUPPORT_EXPORT is for symbols that need to be exported to the Internals library, WebKitTestRunner, etc., but not generally exported for third parties. The definition of WEBCORE_TESTSUPPORT_EXPORT for Windows is in WebCorePrefix.h: #if PLATFORM(WIN) #undef WEBCORE_EXPORT #define WEBCORE_EXPORT WTF_EXPORT_DECLARATION #undef WEBCORE_TESTSUPPORT_EXPORT #define WEBCORE_TESTSUPPORT_EXPORT WTF_EXPORT_DECLARATION Created attachment 366970 [details]
Patch for landing
(In reply to Jer Noble from comment #18) > The intent of WEBCORE_TESTSUPPORT_EXPORT is for symbols that need to be > exported to the Internals library, WebKitTestRunner, etc., but not generally > exported for third parties. Windows doesn't have such export level functionality as far as I know. It can export a symbol or not export it. Comment on attachment 366970 [details] Patch for landing Clearing flags on attachment: 366970 Committed r244078: <https://trac.webkit.org/changeset/244078> All reviewed patches have been landed. Closing bug. |