| Summary: | REGRESSION (r243153): [iPhone] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
| Component: | New Bugs | Assignee: | Daniel Bates <dbates> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, dbates, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar, PlatformOnly, Regression | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | iPhone / iPad | ||||||
| OS: | iOS 12 | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=195820 | ||||||
| Bug Depends on: | 195820 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
This appears to have started with: "[iOS] Focus not preserved when switching between tabs" https://trac.webkit.org/changeset/243153/webkit Dan, would you please take a look? (In reply to Ryan Haddad from comment #0) > The following API test is failing on iOS bots: > > > TestWebKitAPI.FocusPreservationTests. > ChangingFocusedNodeResetsFocusPreservationState > > > /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/ > ios/FocusPreservationTests.mm:100 > Value of: [webView > stringByEvaluatingJavaScript:@"document.activeElement == > document.querySelector('select')"].boolValue > Actual: true > Expected: false > > https://build.webkit.org/builders/ > Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/3212/steps/ > run-api-tests/logs/stdio Progression. Will update test. (In reply to Daniel Bates from comment #3) > (In reply to Ryan Haddad from comment #0) > > The following API test is failing on iOS bots: > > > > > > TestWebKitAPI.FocusPreservationTests. > > ChangingFocusedNodeResetsFocusPreservationState > > > > > > /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/ > > ios/FocusPreservationTests.mm:100 > > Value of: [webView > > stringByEvaluatingJavaScript:@"document.activeElement == > > document.querySelector('select')"].boolValue > > Actual: true > > Expected: false > > > > https://build.webkit.org/builders/ > > Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/3212/steps/ > > run-api-tests/logs/stdio > > Progression. Will update test. This would be a progression on iPad, but these tests are run using an iPhone I think so this is a regression. Test needs to be updated. It was written with blackbox knowledge of the fact that -[WKWebView resignFirstResponder] is what is called when the <select> picker is dismissed when the Done button is pressed. The test wants to press the Done button, but does it in an indirect way. Need to fix test to do what it actually wants to do. Created attachment 365411 [details]
Patch
Committed r243248: <https://trac.webkit.org/changeset/243248> |
The following API test is failing on iOS bots: TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:100 Value of: [webView stringByEvaluatingJavaScript:@"document.activeElement == document.querySelector('select')"].boolValue Actual: true Expected: false https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/3212/steps/run-api-tests/logs/stdio