Bug 196007

Summary:	Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
Product:	WebKit	Reporter:	Aakash Jain <aakash_jain>
Component:	Tools / Tests	Assignee:	Tim Horton <thorton>
Status:	RESOLVED CONFIGURATION CHANGED
Severity:	Normal	CC:	aakash_jain, ap, lforschler, ryanhaddad, thorton, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=195499 https://bugs.webkit.org/show_bug.cgi?id=196006 https://bugs.webkit.org/show_bug.cgi?id=196629

Description Aakash Jain 2019-03-20 07:44:15 PDT

TestWebKitAPI.WebKit.FocusTextInputContext seems flaky. In https://ews-build.webkit-uat.org/#/builders/20/builds/2040, the test Failed in run-api-tests step. However, in the immediately next retry step (re-run-api-tests), it passed.

Similar thing happened in https://ews-build.webkit-uat.org/#/builders/20/builds/2039

Comment 1 Aakash Jain 2019-03-20 09:13:23 PDT

This test was added recently in https://trac.webkit.org/changeset/242696/webkit

Comment 2 Aakash Jain 2019-03-21 13:11:59 PDT

Happened again in: 
https://ews-build.webkit-uat.org/#/builders/20/builds/2197
https://ews-build.webkit-uat.org/#/builders/20/builds/2198

Comment 3 Aakash Jain 2019-03-22 06:10:58 PDT

Also failed in:
https://ews-build.webkit-uat.org/#/builders/20/builds/2228
https://ews-build.webkit-uat.org/#/builders/20/builds/2232

Comment 4 Radar WebKit Bug Importer 2019-03-22 10:43:33 PDT

<rdar://problem/49159433>

Comment 5 Aakash Jain 2019-03-24 04:55:39 PDT

Can we prioritize this?
I am working on EWS for API tests, and this flaky failure is slowing down EWS (since we need to retry in case of any failure), and creating problem (e.g.: https://ews-build.webkit-uat.org/#/builders/20/builds/2254).

Comment 6 Tim Horton 2019-03-25 13:24:44 PDT

Interesting that both FocusTextInputContext and KeyboardTypeForInput, both of which depend on bringing up the keyboard, are frequently failing in the same runs

Comment 7 Aakash Jain 2019-04-04 14:49:22 PDT

This test seems to be failing pretty consistently, few recent examples:

https://ews-build.webkit-uat.org/#/builders/20/builds/2630
https://ews-build.webkit-uat.org/#/builders/20/builds/2629
https://ews-build.webkit-uat.org/#/builders/20/builds/2627
https://ews-build.webkit-uat.org/#/builders/20/builds/2626
https://ews-build.webkit-uat.org/#/builders/20/builds/2625
https://ews-build.webkit-uat.org/#/builders/20/builds/2624
https://ews-build.webkit-uat.org/#/builders/20/builds/2623
https://ews-build.webkit-uat.org/#/builders/20/builds/2622
https://ews-build.webkit-uat.org/#/builders/20/builds/2621
https://ews-build.webkit-uat.org/#/builders/20/builds/2619
https://ews-build.webkit-uat.org/#/builders/20/builds/2618
https://ews-build.webkit-uat.org/#/builders/20/builds/2616
https://ews-build.webkit-uat.org/#/builders/20/builds/2599
https://ews-build.webkit-uat.org/#/builders/20/builds/2614
https://ews-build.webkit-uat.org/#/builders/20/builds/2612
https://ews-build.webkit-uat.org/#/builders/20/builds/2611
https://ews-build.webkit-uat.org/#/builders/20/builds/2610
https://ews-build.webkit-uat.org/#/builders/20/builds/2609
https://ews-build.webkit-uat.org/#/builders/20/builds/2606
https://ews-build.webkit-uat.org/#/builders/20/builds/2604
https://ews-build.webkit-uat.org/#/builders/20/builds/2603
https://ews-build.webkit-uat.org/#/builders/20/builds/2602
https://ews-build.webkit-uat.org/#/builders/20/builds/2601
https://ews-build.webkit-uat.org/#/builders/20/builds/2600

Comment 8 Tim Horton 2019-04-29 23:10:06 PDT

Looks like somebody disabled it.

Comment 9 Aakash Jain 2019-05-06 12:02:56 PDT

(In reply to Tim Horton from comment #8)
> Looks like somebody disabled it.
Yeah, I disabled it in https://bugs.webkit.org/show_bug.cgi?id=196629 since it was so flaky that it was impacting automation (EWS for API test) significantly. Would be nice to have it fixed and re-enabled.

Comment 10 Tim Horton 2019-05-06 12:13:42 PDT

(In reply to Aakash Jain from comment #9)
> (In reply to Tim Horton from comment #8)
> > Looks like somebody disabled it.
> Yeah, I disabled it in https://bugs.webkit.org/show_bug.cgi?id=196629 since
> it was so flaky that it was impacting automation (EWS for API test)
> significantly. Would be nice to have it fixed and re-enabled.

Not for now; see the radar

Comment 11 Daniel Bates 2020-04-28 11:08:21 PDT

I removed this test in the patch for bug #210619 because I replaced -_focusTextInputContext with a new variant. I added tests that cover almost all the functionality tested in the flaky test.