Bug 195999 – Compilation broken in WKWebViewGetContents.mm with iOS SDK (rev 243195)

• Component: Tools / Tests
• Status: RESOLVED FIXED

Compilation is broken with error 

webkit/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:60:14: error: '_getContentsAsAttributedStringWithCompletionHandler:' is unavailable: not available on iOS
    [webView _getContentsAsAttributedStringWithCompletionHandler:^(NSAttributedString *attributedString, NSDictionary<NSAttributedStringDocumentAttributeKey, id> *documentAttributes, NSError *error) {
             ^
In file included from webkit/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:30:
In file included from webkit/Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h:28:
In file included from /webkit/WebKitBuild/Debug-iphonesimulator/WebKit.framework/PrivateHeaders/WKNavigationDelegatePrivate.h:29:
/WebKitBuild/Debug-iphonesimulator/WebKit.framework/PrivateHeaders/WKWebViewPrivate.h:367:1: note: '_getContentsAsAttributedStringWithCompletionHandler:' has been explicitly marked
      unavailable here
- (void)_getContentsAsAttributedStringWithCompletionHandler:(void (^)(NSAttributedString *, NSDictionary<NSAttributedStringDocumentAttributeKey, id> *, NSError *))completionHandler API_AVAILABLE(macosx(NA), ios(NA));
^
1 error generated.

Created attachment 365347 [details]
Initial upload

[Ali Juma]

This typo (WK_MAC_TBA instead of WK_IOS_TBA) unfortunately happens every so often and breaks the open-source iOS build.

[WebKit Commit Bot]

Comment on attachment 365347 [details]
Initial upload

Clearing flags on attachment: 365347

Committed r243212: <https://trac.webkit.org/changeset/243212>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49064939>

[Frédéric Wang (:fredw)]

(In reply to Ali Juma from comment #2)
> This typo (WK_MAC_TBA instead of WK_IOS_TBA) unfortunately happens every so
> often and breaks the open-source iOS build.

I had added a style check in bug 181394 ; I wonder why the error was not caught by check-webkit-style?

[Frédéric Wang (:fredw)]

(In reply to Frédéric Wang (:fredw) from comment #6)
> (In reply to Ali Juma from comment #2)
> > This typo (WK_MAC_TBA instead of WK_IOS_TBA) unfortunately happens every so
> > often and breaks the open-source iOS build.
> 
> I had added a style check in bug 181394 ; I wonder why the error was not
> caught by check-webkit-style?

OK it was actually detected: https://bugs.webkit.org/show_bug.cgi?id=195636#c52

[Timothy Hatcher]

(In reply to Frédéric Wang (:fredw) from comment #7)
> (In reply to Frédéric Wang (:fredw) from comment #6)
> > (In reply to Ali Juma from comment #2)
> > > This typo (WK_MAC_TBA instead of WK_IOS_TBA) unfortunately happens every so
> > > often and breaks the open-source iOS build.
> > 
> > I had added a style check in bug 181394 ; I wonder why the error was not
> > caught by check-webkit-style?
> 
> OK it was actually detected:
> https://bugs.webkit.org/show_bug.cgi?id=195636#c52

Oops, I remember seeing that and not fully understanding / reading it I guess.

"WK_MAC_TBA is neither a version number nor WK_IOS_TBA"

That statement is true, it is not a number nor WK_IOS_TBA — nothing to see here. It sounded (at a glance) like it didn't approve of a define being used — expecting only a number — since macosx(WK_MAC_TBA) was also used on the same line. The missing part is this is about the WK_MAC_TBA  being used in the ios() macro.

An error more like would help:

"ios(WK_MAC_TBA) is invalid; expected WK_IOS_TBA or a number"

I'll file a bug on this.

[Frédéric Wang (:fredw)]

(In reply to Timothy Hatcher from comment #8)
> (In reply to Frédéric Wang (:fredw) from comment #7)
> > (In reply to Frédéric Wang (:fredw) from comment #6)
> > > (In reply to Ali Juma from comment #2)
> > > > This typo (WK_MAC_TBA instead of WK_IOS_TBA) unfortunately happens every so
> > > > often and breaks the open-source iOS build.
> > > 
> > > I had added a style check in bug 181394 ; I wonder why the error was not
> > > caught by check-webkit-style?
> > 
> > OK it was actually detected:
> > https://bugs.webkit.org/show_bug.cgi?id=195636#c52
> 
> Oops, I remember seeing that and not fully understanding / reading it I
> guess.
> 
> "WK_MAC_TBA is neither a version number nor WK_IOS_TBA"
> 
> That statement is true, it is not a number nor WK_IOS_TBA — nothing to see
> here. It sounded (at a glance) like it didn't approve of a define being used
> — expecting only a number — since macosx(WK_MAC_TBA) was also used on the
> same line. The missing part is this is about the WK_MAC_TBA  being used in
> the ios() macro.
> 
> An error more like would help:
> 
> "ios(WK_MAC_TBA) is invalid; expected WK_IOS_TBA or a number"
> 
> I'll file a bug on this.

I see. Thanks.