Summary: | Compilation broken in WKWebViewGetContents.mm with iOS SDK (rev 243195) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | olivierrobin | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ajuma, commit-queue, fred.wang, lforschler, thorton, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | iOS 12 | ||||||
Attachments: |
|
Description
olivierrobin
2019-03-20 06:30:56 PDT
Created attachment 365347 [details]
Initial upload
This typo (WK_MAC_TBA instead of WK_IOS_TBA) unfortunately happens every so often and breaks the open-source iOS build. Comment on attachment 365347 [details] Initial upload Clearing flags on attachment: 365347 Committed r243212: <https://trac.webkit.org/changeset/243212> All reviewed patches have been landed. Closing bug. (In reply to Ali Juma from comment #2) > This typo (WK_MAC_TBA instead of WK_IOS_TBA) unfortunately happens every so > often and breaks the open-source iOS build. I had added a style check in bug 181394 ; I wonder why the error was not caught by check-webkit-style? (In reply to Frédéric Wang (:fredw) from comment #6) > (In reply to Ali Juma from comment #2) > > This typo (WK_MAC_TBA instead of WK_IOS_TBA) unfortunately happens every so > > often and breaks the open-source iOS build. > > I had added a style check in bug 181394 ; I wonder why the error was not > caught by check-webkit-style? OK it was actually detected: https://bugs.webkit.org/show_bug.cgi?id=195636#c52 (In reply to Frédéric Wang (:fredw) from comment #7) > (In reply to Frédéric Wang (:fredw) from comment #6) > > (In reply to Ali Juma from comment #2) > > > This typo (WK_MAC_TBA instead of WK_IOS_TBA) unfortunately happens every so > > > often and breaks the open-source iOS build. > > > > I had added a style check in bug 181394 ; I wonder why the error was not > > caught by check-webkit-style? > > OK it was actually detected: > https://bugs.webkit.org/show_bug.cgi?id=195636#c52 Oops, I remember seeing that and not fully understanding / reading it I guess. "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" That statement is true, it is not a number nor WK_IOS_TBA — nothing to see here. It sounded (at a glance) like it didn't approve of a define being used — expecting only a number — since macosx(WK_MAC_TBA) was also used on the same line. The missing part is this is about the WK_MAC_TBA being used in the ios() macro. An error more like would help: "ios(WK_MAC_TBA) is invalid; expected WK_IOS_TBA or a number" I'll file a bug on this. (In reply to Timothy Hatcher from comment #8) > (In reply to Frédéric Wang (:fredw) from comment #7) > > (In reply to Frédéric Wang (:fredw) from comment #6) > > > (In reply to Ali Juma from comment #2) > > > > This typo (WK_MAC_TBA instead of WK_IOS_TBA) unfortunately happens every so > > > > often and breaks the open-source iOS build. > > > > > > I had added a style check in bug 181394 ; I wonder why the error was not > > > caught by check-webkit-style? > > > > OK it was actually detected: > > https://bugs.webkit.org/show_bug.cgi?id=195636#c52 > > Oops, I remember seeing that and not fully understanding / reading it I > guess. > > "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" > > That statement is true, it is not a number nor WK_IOS_TBA — nothing to see > here. It sounded (at a glance) like it didn't approve of a define being used > — expecting only a number — since macosx(WK_MAC_TBA) was also used on the > same line. The missing part is this is about the WK_MAC_TBA being used in > the ios() macro. > > An error more like would help: > > "ios(WK_MAC_TBA) is invalid; expected WK_IOS_TBA or a number" > > I'll file a bug on this. I see. Thanks. |