| Summary: | [ews-build] Improve failure summary string for ApplyPatch step | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, dewei_zhu, ews-watchlist, jbedard, lforschler, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2019-03-20 04:05:33 PDT
Created attachment 365335 [details]
Patch
Attachment 365335 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:138: [ApplyPatch.getResultSummary] Use of super on an old style class [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:139: [ApplyPatch.getResultSummary] Instance of 'ApplyPatch' has no 'results' member [pylint/E1101] [5]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
I'm having second thoughts about making Buildbot changes to tweak status bubble content. It's useful to have good text messages in Buildbot UI too. However, relying on Buildbot as authoritative source of status bubble UI text will become problematic once the system is in production, as we don't want to restart Buildbot often. So a less intrusive way to polish UI will need to be added. Comment on attachment 365335 [details] Patch Clearing flags on attachment: 365335 Committed r243217: <https://trac.webkit.org/changeset/243217> All reviewed patches have been landed. Closing bug. |