Bug 195995

Summary:

[ews-build] Improve failure summary string for ApplyPatch step

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, dewei_zhu, ews-watchlist, jbedard, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	dewei_zhu: review+

Aakash Jain

Reported 2019-03-20 04:05:33 PDT

When ApplyPatch step fails, the buildbot generated summary is: 'Applied patch (failure)'. This isn't good and might be confusing. We should improve this to something like: 'Patch does not apply'.

Attachments
Patch (1.34 KB, patch) 2019-03-20 04:08 PDT, Aakash Jain	dewei_zhu: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-03-20 04:08:34 PDT

Created attachment 365335 [details] Patch

EWS Watchlist

Comment 2 2019-03-20 04:11:26 PDT Comment hidden (obsolete)

Attachment 365335 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:138: [ApplyPatch.getResultSummary] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:139: [ApplyPatch.getResultSummary] Instance of 'ApplyPatch' has no 'results' member [pylint/E1101] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alexey Proskuryakov

Comment 3 2019-03-20 10:26:03 PDT

I'm having second thoughts about making Buildbot changes to tweak status bubble content. It's useful to have good text messages in Buildbot UI too. However, relying on Buildbot as authoritative source of status bubble UI text will become problematic once the system is in production, as we don't want to restart Buildbot often. So a less intrusive way to polish UI will need to be added.

WebKit Commit Bot

Comment 4 2019-03-20 11:10:37 PDT

Comment on attachment 365335 [details] Patch Clearing flags on attachment: 365335 Committed r243217: <https://trac.webkit.org/changeset/243217>

WebKit Commit Bot

Comment 5 2019-03-20 11:10:38 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2019-03-20 11:13:18 PDT

<rdar://problem/49069801>

Note You need to log in before you can comment on or make changes to this bug.