Bug 195992

Summary:

[JSC] Use finalizer in JSGlobalLexicalEnvironment and JSGlobalObject

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch for landing	none

Yusuke Suzuki

Reported 2019-03-20 01:18:10 PDT

[JSC] Use finalizer in JSGlobalLexicalEnvironment and JSGlobalObject

Attachments
Patch (20.62 KB, patch) 2019-03-20 01:25 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (20.80 KB, patch) 2019-03-20 11:12 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (22.51 KB, patch) 2019-03-20 11:42 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (22.58 KB, patch) 2019-03-20 11:43 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (22.92 KB, patch) 2019-03-20 12:17 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.95 MB, application/zip) 2019-03-20 16:51 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.56 MB, application/zip) 2019-03-20 17:21 PDT, EWS Watchlist	no flags	Details
Patch for landing (24.86 KB, patch) 2019-03-20 21:20 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2019-03-20 01:25:41 PDT

Created attachment 365326 [details] Patch

Yusuke Suzuki

Comment 2 2019-03-20 01:27:24 PDT

Comment on attachment 365326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365326&action=review > Source/JavaScriptCore/ChangeLog:12 > + memory / performance problems (actually, previously we used finalizer for ArrayPrototype due to the same reason, and it does not show any problems). BTW, I'm now planning to reorganize JSScope things to make JSScope cells non JSObject. Once it is done, we can remove this finalizer too (use destructible JSCell for JSGlobalLexcailEnvrionment, and JSDestrucitbleObject for JSGlobalObject).

EWS Watchlist

Comment 3 2019-03-20 05:23:16 PDT

Comment on attachment 365326 [details] Patch Attachment 365326 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/11578437 New failing tests: stress/regress-189028.js.no-cjit-validate-phases stress/regress-189028.js.bytecode-cache stress/regress-189028.js.ftl-eager-no-cjit stress/regress-189028.js.dfg-eager-no-cjit-validate stress/regress-189028.js.dfg-eager stress/regress-189028.js.ftl-no-cjit-no-inline-validate stress/regress-189028.js.no-llint stress/regress-189028.js.default stress/regress-189028.js.no-ftl stress/regress-189028.js.dfg-maximal-flush-validate-no-cjit stress/regress-189028.js.ftl-eager stress/regress-189028.js.ftl-no-cjit-small-pool stress/regress-189028.js.ftl-no-cjit-no-put-stack-validate stress/regress-189028.js.ftl-eager-no-cjit-b3o1 stress/regress-189028.js.ftl-no-cjit-b3o0 stress/regress-189028.js.ftl-no-cjit-validate-sampling-profiler stress/regress-189028.js.no-cjit-collect-continuously apiTests

Yusuke Suzuki

Comment 4 2019-03-20 11:12:07 PDT

Created attachment 365363 [details] Patch

Keith Miller

Comment 5 2019-03-20 11:20:40 PDT

Comment on attachment 365363 [details] Patch r=me.

Mark Lam

Comment 6 2019-03-20 11:22:52 PDT

Comment on attachment 365363 [details] Patch r=me too

Yusuke Suzuki

Comment 7 2019-03-20 11:42:26 PDT

Created attachment 365369 [details] Patch Fix WebCore side. Use cellHeapCellType since JSSegmentedVariableObject already set finalizer.

Yusuke Suzuki

Comment 8 2019-03-20 11:43:55 PDT

Created attachment 365371 [details] Patch Fix WebCore side. Use cellHeapCellType since JSSegmentedVariableObject already set finalizer.

Yusuke Suzuki

Comment 9 2019-03-20 12:17:38 PDT

Created attachment 365382 [details] Patch

EWS Watchlist

Comment 10 2019-03-20 16:51:04 PDT

Comment on attachment 365382 [details] Patch Attachment 365382 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11586909 New failing tests: http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html

EWS Watchlist

Comment 11 2019-03-20 16:51:06 PDT

Created attachment 365438 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 12 2019-03-20 17:21:01 PDT

Comment on attachment 365382 [details] Patch Attachment 365382 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11586830 New failing tests: fast/visual-viewport/ios/min-scale-greater-than-one.html

EWS Watchlist

Comment 13 2019-03-20 17:21:02 PDT

Created attachment 365444 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Yusuke Suzuki

Comment 14 2019-03-20 21:20:11 PDT

Created attachment 365480 [details] Patch for landing

Yusuke Suzuki

Comment 15 2019-03-20 21:20:38 PDT

Comment on attachment 365480 [details] Patch for landing Oops, accidentally cleared r+.

Yusuke Suzuki

Comment 16 2019-03-20 21:21:10 PDT

(In reply to Build Bot from comment #13) > Created attachment 365444 [details] > Archive of layout-test-results from ews122 for ios-simulator-wk2 > > The attached test failures were seen while running run-webkit-tests on the > ios-sim-ews. > Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6 After checking these crashes, it seems unrelated. I'll land it after rechecking EWS status.

Yusuke Suzuki

Comment 17 2019-03-21 00:00:28 PDT

Committed r243279: <https://trac.webkit.org/changeset/243279>

Radar WebKit Bug Importer

Comment 18 2019-03-21 00:01:35 PDT

<rdar://problem/49097562>

Note You need to log in before you can comment on or make changes to this bug.