Summary: | [ Mac WK2 ] Layout Test js/dom/unhandled-promise-rejection-bindings-type-error.html is a flaky failure | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shawn Roberts <sroberts> | ||||
Component: | Tools / Tests | Assignee: | Devin Rousso <hi> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, commit-queue, hi, joepeck, lforschler, saam, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Shawn Roberts
2019-03-19 15:50:56 PDT
It is possible for this to fail if somehow the 100ms timeout fires before promise rejections are handled. Which in practice should never happen... --debug will certainly make things slower -g is libgmalloc which will make the tests slower still -f is fully parallel which shouldn't do much Perhaps there is something better for the test to use instead of setTimeout. Maybe queueMicrotask a few times? Created attachment 369707 [details]
Patch
Comment on attachment 369707 [details] Patch Clearing flags on attachment: 369707 Committed r245256: <https://trac.webkit.org/changeset/245256> All reviewed patches have been landed. Closing bug. |