Bug 195963 – [ews-build] Improve summary for CheckOutSource step

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Aakash Jain]

The summary automatically generated by Buildbot for CheckOutSource step (which uses Buildbot base class git.Git) is 'update'. We should improve this.

Buildbot doesn't seem to respect descriptionDone for git.Git class. Reference: https://github.com/buildbot/buildbot/issues/4666

[Aakash Jain]

Created attachment 365229 [details]
Patch

[EWS Watchlist]

Attachment 365229 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:100:  [CheckOutSource.getResultSummary] Instance of 'CheckOutSource' has no 'results' member  [pylint/E1101] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Aakash Jain]

Sample run: https://ews-build.webkit-uat.org/#/builders/19/builds/2215

[Lucas Forschler]

Comment on attachment 365229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365229&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:103
> +

I think you should not abbreviate summary as 'summ'.  
it only saves a couple chars, so just use stepsummary or step_summary.  or, just 'summary'

this could also be written:
if self.results != SUCCESS:
    return {u'step': u'Failed to updated working directory'}
else:
     return {u'step': u'Cleaned and updated working directory' }

which avoids the variable name altogether.

[Aakash Jain]

Committed r243174: <https://trac.webkit.org/changeset/243174>

[Aakash Jain]

> this could also be written:
Thanks. used this.

[Radar WebKit Bug Importer]

<rdar://problem/49038313>