Bug 195963

Summary: [ews-build] Improve summary for CheckOutSource step
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, dewei_zhu, ews-watchlist, jbedard, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch lforschler: review+

Description Aakash Jain 2019-03-19 14:43:18 PDT
The summary automatically generated by Buildbot for CheckOutSource step (which uses Buildbot base class git.Git) is 'update'. We should improve this.

Buildbot doesn't seem to respect descriptionDone for git.Git class. Reference: https://github.com/buildbot/buildbot/issues/4666
Comment 1 Aakash Jain 2019-03-19 14:46:46 PDT
Created attachment 365229 [details]
Patch
Comment 2 EWS Watchlist 2019-03-19 14:48:02 PDT Comment hidden (obsolete)
Comment 3 Aakash Jain 2019-03-19 14:48:51 PDT
Sample run: https://ews-build.webkit-uat.org/#/builders/19/builds/2215
Comment 4 Lucas Forschler 2019-03-19 15:10:24 PDT
Comment on attachment 365229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365229&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:103
> +

I think you should not abbreviate summary as 'summ'.  
it only saves a couple chars, so just use stepsummary or step_summary.  or, just 'summary'

this could also be written:
if self.results != SUCCESS:
    return {u'step': u'Failed to updated working directory'}
else:
     return {u'step': u'Cleaned and updated working directory' }

which avoids the variable name altogether.
Comment 5 Aakash Jain 2019-03-19 15:22:54 PDT
Committed r243174: <https://trac.webkit.org/changeset/243174>
Comment 6 Aakash Jain 2019-03-19 15:24:34 PDT
> this could also be written:
Thanks. used this.
Comment 7 Radar WebKit Bug Importer 2019-03-19 15:24:53 PDT
<rdar://problem/49038313>