Bug 195959

Summary:

Web Inspector: refactor WI.TimelineDataGridNode and its subclasses to unify the API surface

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

191901

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none

Devin Rousso

Reported 2019-03-19 11:58:26 PDT

Unify the API surface of all of the `WI.TimelineDataGridNode` subclasses so that they can all work nicely with the `WI.OverviewTimelineView`.

Attachments
Patch (64.89 KB, patch) 2019-03-19 13:02 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.99 MB, application/zip) 2019-03-19 14:48 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-03-19 11:59:36 PDT

<rdar://problem/49028896>

Devin Rousso

Comment 2 2019-03-19 13:02:25 PDT

Created attachment 365214 [details] Patch

EWS Watchlist

Comment 3 2019-03-19 14:48:48 PDT Comment hidden (obsolete)

Comment on attachment 365214 [details] Patch Attachment 365214 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11570494 New failing tests: http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html

EWS Watchlist

Comment 4 2019-03-19 14:48:50 PDT Comment hidden (obsolete)

Created attachment 365230 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

WebKit Commit Bot

Comment 5 2019-03-20 10:43:10 PDT

Comment on attachment 365214 [details] Patch Clearing flags on attachment: 365214 Committed r243213: <https://trac.webkit.org/changeset/243213>

WebKit Commit Bot

Comment 6 2019-03-20 10:43:12 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.